Skip to content

BR: retry for PD request error and TiKV IO error#27803

Merged
ti-chi-bot merged 10 commits intopingcap:masterfrom
joccau:bugfix-retry-pdRequest
Sep 6, 2021
Merged

BR: retry for PD request error and TiKV IO error#27803
ti-chi-bot merged 10 commits intopingcap:masterfrom
joccau:bugfix-retry-pdRequest

Conversation

@joccau
Copy link
Contributor

@joccau joccau commented Sep 3, 2021

What problem does this PR solve?

Issue Number: close #27787

What is changed and how it works?

What's Changed:
(1)Add TiKV "timeout" storage error into retryable errors
(2)Add WithRetry whenGetAllTiKVStores() when request for PD

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Little-Wallace
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2021
@joccau joccau closed this Sep 3, 2021
@joccau joccau reopened this Sep 4, 2021
@joccau
Copy link
Contributor Author

joccau commented Sep 4, 2021

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Sep 4, 2021
@joccau
Copy link
Contributor Author

joccau commented Sep 4, 2021

/sig migrate

@joccau
Copy link
Contributor Author

joccau commented Sep 4, 2021

/cc @3pointer @YuJuncen

@joccau
Copy link
Contributor Author

joccau commented Sep 6, 2021

/run-integration-tests

@joccau
Copy link
Contributor Author

joccau commented Sep 6, 2021

/run-all-tests

Little-Wallace
Little-Wallace approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021
@kennytm
Copy link
Contributor

kennytm commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7ad0d47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

@joccau: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e3ae921 into pingcap:master Sep 6, 2021
@joccau joccau deleted the bugfix-retry-pdRequest branch September 7, 2021 04:37
joccau added a commit to joccau/tidb that referenced this pull request Sep 7, 2021
@joccau
BR: retry for PD request error and TiKV IO error (pingcap#27803)
5f17817
@joccau joccau mentioned this pull request Sep 7, 2021
Merged
This was referenced Sep 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm approved these changes

@Little-Wallace Little-Wallace Little-Wallace approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees

No one assigned

Labels

component/br This issue is related to BR of TiDB. release-note-none Denotes a PR that doesn't merit a release note. sig/migrate size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BR: retry for PD request error and TiKV IO error.

4 participants

@joccau @ti-chi-bot @kennytm @Little-Wallace