Skip to content

statistics: fix two unstable tests#27430

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
rebelice:fix_two_tests
Aug 20, 2021
Merged

statistics: fix two unstable tests#27430
ti-chi-bot merged 5 commits intopingcap:masterfrom
rebelice:fix_two_tests

Conversation

@rebelice
Copy link
Contributor

@rebelice rebelice commented Aug 20, 2021

What problem does this PR solve?

Issue Number: close #24010, close #24679

Problem Summary:

What is changed and how it works?

Proposal: xxx

Change two tests to serial tests.

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None.

@rebelice rebelice added the sig/planner SIG: Planner label Aug 20, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 20, 2021
@qw4990
Copy link
Contributor

qw4990 commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 93b2dcc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Aug 20, 2021

/merge

@tisonkun
Copy link
Contributor

tisonkun commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

@tisonkun: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Aug 20, 2021

@ti-chi-bot

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Aug 20, 2021

/run-check_dev_2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

@rebelice: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 20, 2021

/run-check_dev_2

@tisonkun
Copy link
Contributor

tisonkun commented Aug 20, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021

@tisonkun: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7e62444 into pingcap:master Aug 20, 2021
0xPoe added a commit to 0xPoe/tidb that referenced this pull request Aug 20, 2021
@0xPoe
Revert "statistics: fix two unstable tests (pingcap#27430)"
1fb015c 
This reverts commit 7e62444.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestAnalyzeGlobalStatsWithOpts2 test failed unstable test case TestAnalyzeGlobalStatsWithOpts

6 participants

@rebelice @ti-chi-bot @qw4990 @tisonkun @zhouqiang-cl @time-and-fate