Skip to content

executor: fix several analyze related unstable tests#26875

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
time-and-fate:issue26684
Aug 4, 2021
Merged

executor: fix several analyze related unstable tests#26875
ti-chi-bot merged 3 commits intopingcap:masterfrom
time-and-fate:issue26684

Conversation

@time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Aug 4, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #26684 close #25188 close #14931

What is changed and how it works?

Stabilize unstable tests caused by concurrent read and write of global variables.

  • Put the cases that need to modify FeedbackProbability into a serial suite.
  • In TestShowAnalyzeStatus, test analyze ver2 first and then analyze ver1 to avoid failure to switch from ver1 to ver2.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 4, 2021
@time-and-fate
Copy link
Member Author

time-and-fate commented Aug 4, 2021

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Aug 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@time-and-fate
Copy link
Member Author

time-and-fate commented Aug 4, 2021

/label needs-cherry-pick-5.1

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 4, 2021
@Reminiscent
Copy link
Contributor

Reminiscent commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bb17ea4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021
@time-and-fate
Copy link
Member Author

time-and-fate commented Aug 4, 2021

/run-check-title

@time-and-fate
Copy link
Member Author

time-and-fate commented Aug 4, 2021

/run-check_dev_2
/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Aug 4, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit f8d420b into pingcap:master Aug 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 4, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#26875 to release-5.1
5cbfca0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Aug 4, 2021

cherry pick to release-5.1 in PR #26893

ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@ti-srebot
executor: fix several analyze related unstable tests (#26875) (#26893)
afbda5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.1 release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

5 participants

@time-and-fate @ti-chi-bot @Reminiscent @qw4990 @ti-srebot