Skip to content

Revert "expression: Fix greatest and least function lost decimal precision compared with MySQL"#26046

Merged
ti-chi-bot merged 2 commits intomasterfrom
revert-25766-fix_greatest
Jul 9, 2021
Merged

Revert "expression: Fix greatest and least function lost decimal precision compared with MySQL"#26046
ti-chi-bot merged 2 commits intomasterfrom
revert-25766-fix_greatest

Conversation

@lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Jul 8, 2021

Reverts #25766

to close #26018

The origin PR is not correct. We decide to revert it.

Release note

  • None

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 8, 2021
Closed
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2021
@lzmhhh123
Copy link
Contributor Author

lzmhhh123 commented Jul 9, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 89a0881

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2021

@lzmhhh123: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit eedb191 into master Jul 9, 2021
@ti-chi-bot ti-chi-bot deleted the revert-25766-fix_greatest branch July 9, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

Assignees

No one assigned

Labels

component/expression size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integration test break by #25766

4 participants

@lzmhhh123 @ti-chi-bot @wshwsh12 @ichn-hu