Skip to content

expression: Fix greatest and least function lost decimal precision compared with MySQL#25766

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
yuqi1129:fix_greatest
Jul 7, 2021
Merged

expression: Fix greatest and least function lost decimal precision compared with MySQL#25766
ti-chi-bot merged 11 commits intopingcap:masterfrom
yuqi1129:fix_greatest

Conversation

@yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Jun 25, 2021

What problem does this PR solve?

Issue Number: close #25765

Problem Summary:
Greatest and least function lost decimal precision compared with MySQL
see:
select greatest(1.0, 2) return 2 while MySQL returns 2.0

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@yuqi1129 yuqi1129 requested a review from a team as a code owner June 25, 2021 11:05
@yuqi1129 yuqi1129 requested review from lzmhhh123 and removed request for a team June 25, 2021 11:05
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 26, 2021
Closed
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jun 28, 2021

/assign @lzmhhh123

lzmhhh123
lzmhhh123 reviewed Jun 28, 2021
View reviewed changes
@lzmhhh123 lzmhhh123 removed their assignment Jun 28, 2021
@yuqi1129 yuqi1129 changed the title expression: Fix Greatest and least function lost decimal precision compared with MySQL expression: Fix greatest and least function lost decimal precision compared with MySQL Jun 28, 2021
lzmhhh123
lzmhhh123 reviewed Jun 30, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2021
@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jun 30, 2021

/cc @AilinKid

@ti-chi-bot ti-chi-bot requested a review from AilinKid June 30, 2021 08:06
@lzmhhh123
Copy link
Contributor

lzmhhh123 commented Jul 2, 2021

/cc @ichn-hu

@ti-chi-bot ti-chi-bot requested a review from ichn-hu July 2, 2021 05:08
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2021
@yuqi1129
Copy link
Contributor Author

yuqi1129 commented Jul 6, 2021

@ichn-hu , Can you help to review this PR ?

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2021
@ichn-hu
Copy link
Contributor

ichn-hu commented Jul 7, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: acfd81a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 7, 2021

@yuqi1129: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3c3096e into pingcap:master Jul 7, 2021
@zhouqiang-cl zhouqiang-cl mentioned this pull request Jul 7, 2021
Closed
lzmhhh123 added a commit that referenced this pull request Jul 8, 2021
@lzmhhh123
Revert "expression: Fix greatest and least function lost decimal prec…
89a0881 
…ision compared with MySQL (#25766)"

This reverts commit 3c3096e.
@lzmhhh123 lzmhhh123 mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

+1 more reviewer

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/expression size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Greatest and least function lost decimal precision compared with MySQL

5 participants

@yuqi1129 @CLAassistant @lzmhhh123 @ti-chi-bot @ichn-hu