expression/expressions: replace iconv-go with text/transform#26
Closed
unknwon wants to merge 1 commit intopingcap:masterfrom
unknwon:master
Closed
expression/expressions: replace iconv-go with text/transform#26unknwon wants to merge 1 commit intopingcap:masterfrom unknwon:master
unknwon wants to merge 1 commit intopingcap:masterfrom
unknwon:master
Conversation
Remove CGO requirement for compiling iconv-go currently is using. Replace it with native implmentation of Go. Signed-off-by: Unknwon <u@gogs.io>
Contributor
Author
|
Opps.... didn't do godep, let me try again. |
|
@unknwon Please update the godep. |
Contributor
Author
|
What is commands for godep 😂 |
|
@unknwon godep save -r ./... |
Contributor
Author
|
OK, pushed the wrong thing. Let me re-fork to keep commits clean. |
Contributor
Author
|
PS: should put this in the README. |
|
@ngaut Can you please add a dependency management section to docs/CONTRIBUTING.md? Thanks a lot! |
Contributor
Author
|
Will do |
Contributor
Author
|
But It feels very strange to me.. |
|
@unknwon Oh... they do not use rewrite? then remove -r. |
Contributor
Author
|
I have no idea why travis failed, and how to update godep. |
tiancaiamao
pushed a commit
to tiancaiamao/tidb
that referenced
this pull request
Oct 14, 2020
ddl: support range multi-columns
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* Remove compact tables and checksum tables 1. TiKV can only do full compaction in import mode, so it is meaningless to compact tables one by one. 2. We can do checksum in TiDB, so we don't need an extra checksum command here. * Remove timer
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* utils: implement worker pool Signed-off-by: 5kbpers <tangminghua@pingcap.com> * restore: limit concurrency of each table Signed-off-by: 5kbpers <tangminghua@pingcap.com> * *: go fmt Signed-off-by: 5kbpers <tangminghua@pingcap.com> * utils, restore: add comments Signed-off-by: 5kbpers <tangminghua@pingcap.com> * address comments Signed-off-by: 5kbpers <tangminghua@pingcap.com> * address comments Signed-off-by: 5kbpers <tangminghua@pingcap.com>
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
* *: add integration test for dumping in given file size
* log: use zap.Error instead of zap.String('err', xx)
* *: fix style problems
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jan 7, 2022
refine show create table
Defined2014
added a commit
to Defined2014/tidb
that referenced
this pull request
Apr 11, 2022
BornChanger
added a commit
to BornChanger/tidb
that referenced
this pull request
Dec 6, 2022
…ap#26) Signed-off-by: BornChanger <dawn_catcher@126.com>
Connor1996
pushed a commit
to Connor1996/tidb
that referenced
this pull request
Dec 14, 2022
…ap#26) Signed-off-by: BornChanger <dawn_catcher@126.com> Signed-off-by: BornChanger <dawn_catcher@126.com>
rleungx
pushed a commit
to rleungx/tidb
that referenced
this pull request
Feb 26, 2024
* init * audit: init first version of audit log * audit: support log global rotate * audit: update log keys * audit: more common notify implement * audit: add record id * audit: rename some names * audit: default use normal log path * audit: add server ip info * audit: do some refine * audit: Add some log keys * audit: update some item format * audit: add stmt demo * audit: support redact * audit: fix bug * audit: update filter * audit: update filter * audit: check user * audit: update * update * audit: update * audit: fix bug * aduit: update * audit: update * update * update * audit: add filter unit test * fmt * Add tests for `tidb_audit_enabled` and `tidb_audit_log` * Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime` * Add tests for `tidb_audit_log_reserved_*` * TODO: TestAuditLogRedact * Fininsh `TestAuditLogRedact` * Update (pingcap#1) * fix typo (pingcap#2) * Add `TRANSACTION` * rename sysvar * audit_log_create_filter, audit_log_remove_filter * finish function call and table test * test privilege * finish test for sysvar * TODO: TestConnectionEvenClass * update * audit: fix lint for audit log (pingcap#1) * audit: fix UT failure caused by the change of redact log (pingcap#3) * audit: use `t.TempDir()` to make test stable (pingcap#4) * audit: fix test failed for 7.1 * Add `OWNERS` file (pingcap#35) Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> * audit: fix panic when logging sometime (pingcap#26) (pingcap#31) * test: fix unstable test TestAuditLogReservedDays (pingcap#8) * Format sysvar_test.go * audit: use `StatementContext` to generate redacted SQL (pingcap#9) * audit: fix panic when logging sometime (pingcap#26) * update * add owner * Update OWNERS --------- Co-authored-by: CbcWestwolf <1004626265@qq.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> * audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39) * This is an automated cherry-pick of pingcap#37 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * fix conflict --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * extension/audit: introduce serverless audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * update bazel config Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * support enable audit log when activate Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * add gwconnid to audit log Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> * comment unstable test * update bazel * add log about activate request * diff audit log enabled * audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45) * This is an automated cherry-pick of pingcap#44 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update util.go --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: 王超 <cclcwangchao@hotmail.com> * Update extension/serverless/OWNERS --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com> Co-authored-by: Chao Wang <cclcwangchao@hotmail.com> Co-authored-by: cbcwestwolf <1004626265@qq.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: Yuqing Bai <baiyuq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove CGO requirement for compiling iconv-go currently is using.
Replace it with native implmentation of Go.
Signed-off-by: Unknwon u@gogs.io
maketest has passed, but test cases don't look very detailed onexpression, so not sure if everything will go well.