Skip to content

expression: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash.#25097

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
LittleFall:enhance/functions
Jun 4, 2021
Merged

expression: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash.#25097
ti-chi-bot merged 7 commits intopingcap:masterfrom
LittleFall:enhance/functions

Conversation

@LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jun 3, 2021

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1480, #22899

Problem Summary: Support push fucntion year,day,datediff,datesub,castTimeAsString down to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: no need

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Support push fucntion year,day,datediff,datesub(datetime sub int, string sub int),castTimeAsString and concat_ws down to TiFlash.

@LittleFall LittleFall requested a review from a team as a code owner June 3, 2021 09:13
@LittleFall LittleFall requested review from lzmhhh123 and removed request for a team June 3, 2021 09:13
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
@LittleFall LittleFall force-pushed the enhance/functions branch from 5293196 to 286fc0e Compare June 3, 2021 09:27
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 3, 2021
@LittleFall LittleFall changed the title expression: Support push fucntion year,day,datediff,datesub,castTimeAsString down to TiFlash. expression: Support push function year,day,datediff,datesub,castTimeAsString down to TiFlash. Jun 3, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@LittleFall LittleFall changed the title expression: Support push function year,day,datediff,datesub,castTimeAsString down to TiFlash. expression: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/unmerge

@LittleFall
Copy link
Contributor Author

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 28e16c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 6154335 into pingcap:master Jun 4, 2021
@LittleFall LittleFall deleted the enhance/functions branch June 4, 2021 02:26
@LittleFall
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression needs-cherry-pick-release-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need support more function pushdown in TiFlash

5 participants