Skip to content

expression: support str_to_date push to TiFlash#25095

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
JaySon-Huang:str_to_date_pushdown
Jun 3, 2021
Merged

expression: support str_to_date push to TiFlash#25095
ti-chi-bot merged 6 commits intopingcap:masterfrom
JaySon-Huang:str_to_date_pushdown

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 3, 2021 •
edited
Loading

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: relate to pingcap/tiflash#1942

Problem Summary:
Function: push str_to_date to TiFlash.

What is changed and how it works?

Add push down support for str_to_date

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Support pushing down the str_to_date functions to TiFlash

@JaySon-Huang
expression: support str_to_date push down to tiflash
231ffd9 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang requested a review from a team as a code owner June 3, 2021 08:30
@JaySon-Huang JaySon-Huang requested review from qw4990 and removed request for a team June 3, 2021 08:30
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2021
jackysp
jackysp approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 3, 2021
Closed
zanmato1984
zanmato1984 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021 


[2021-06-03T08:34:00.960Z] FAIL: pessimistic_test.go:1987: testPessimisticSuite.TestSelectForUpdateWaitSeconds
[2021-06-03T08:34:00.960Z] 
[2021-06-03T08:34:00.960Z] pessimistic_test.go:2023:
[2021-06-03T08:34:00.960Z]     c.Assert(waitErr, NotNil)
[2021-06-03T08:34:00.960Z] ... value = nil
[2021-06-03T08:34:00.960Z] 
[2021-06-03T08:34:00.960Z] 
[2021-06-03T08:34:00.960Z] ----------------------------------------------------------------------
[2021-06-03T08:34:00.960Z] SKIP: pessimistic_test.go:231: testPessimisticSuite.TestSingleStatementRollback (skip with tikv because cluster manipulate is not available)
[2021-06-03T08:34:04.293Z] [2021/06/03 16:34:04.085 +08:00] [ERROR] [handle.go:683] ["[stats] dump stats delta fail"] [error="session pool closed"] [errorVerbose="session pool closed\ngithub.com/pingcap/tidb/domain.(*sessionPool).Get\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/domain/domain.go:801\ngithub.com/pingcap/tidb/statistics/handle.(*Handle).withRestrictedSQLExecutor\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:113\ngithub.com/pingcap/tidb/statistics/handle.(*Handle).execRestrictedSQL\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:124\ngithub.com/pingcap/tidb/statistics/handle.(*Handle).dumpTableStatColSizeToKV\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/statistics/handle/update.go:514\ngithub.com/pingcap/tidb/statistics/handle.(*Handle).DumpStatsDeltaToKV\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/statistics/handle/update.go:432\ngithub.com/pingcap/tidb/statistics/handle.(*Handle).FlushStats\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:682\ngithub.com/pingcap/tidb/domain.(*Domain).updateStatsWorker\n\t/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/domain/domain.go:1262\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1371"]
[2021-06-03T08:34:06.873Z] OOPS: 52 passed, 2 skipped, 1 FAILED
[2021-06-03T08:34:06.873Z] --- FAIL: TestT (81.02s)

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-check_dev_2

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021 

[2021-06-03T08:55:25.211Z] cd tools/check; \
[2021-06-03T08:55:25.211Z] GO111MODULE=on go build -o ../bin/failpoint-ctl github.com/pingcap/failpoint/failpoint-ctl
[2021-06-03T08:55:35.309Z] /bin/sh: Rewrite: command not found
[2021-06-03T08:55:35.309Z] make: *** [failpoint-enable] Error 127

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-check_dev_2

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/assign @zanmato1984

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fb6f56c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/assign @JaySon-Huang

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/merge

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-check_dev_2

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-check_dev_2

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-integration-common-test

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-integration-compatibility-test

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/merge

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 3, 2021

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 0908928 into pingcap:master Jun 3, 2021
@JaySon-Huang JaySon-Huang deleted the str_to_date_pushdown branch June 3, 2021 10:49
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 4, 2021

/label needs-cherry-pick-5.0

@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#25095 to release-5.0
f15153e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 4, 2021

cherry pick to release-5.0 in PR #25148

ti-chi-bot pushed a commit that referenced this pull request Jun 18, 2021
@ti-srebot
expression: support str_to_date push to TiFlash (#25095) (#25148)
4c5046f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@jackysp jackysp jackysp approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@zanmato1984 zanmato1984

@JaySon-Huang JaySon-Huang

Labels

needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JaySon-Huang @ti-chi-bot @ti-srebot @zanmato1984 @jackysp