Skip to content

expression: push Concat and UnixTimestamp to TiFlash#24845

Merged
zanmato1984 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patchfrom
LittleFall:patch-concat,unixtimestamp
May 23, 2021
Merged

expression: push Concat and UnixTimestamp to TiFlash#24845
zanmato1984 merged 1 commit intopingcap:hanfei/release5.0-hotfix-tiflash-patchfrom
LittleFall:patch-concat,unixtimestamp

Conversation

@LittleFall
Copy link
Contributor

@LittleFall LittleFall commented May 23, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@LittleFall LittleFall requested a review from a team as a code owner May 23, 2021 11:16
@LittleFall LittleFall requested review from lzmhhh123 and removed request for a team May 23, 2021 11:16
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2021
@LittleFall
Copy link
Contributor Author

LittleFall commented May 23, 2021

/assign @zanmato1984

@LittleFall
Copy link
Contributor Author

LittleFall commented May 23, 2021

/cc @zanmato1984

@ti-chi-bot ti-chi-bot requested a review from zanmato1984 May 23, 2021 11:16
@sre-bot
Copy link
Contributor

sre-bot commented May 23, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@LittleFall LittleFall changed the title push Concat and UnixTimestamp to TiFlash expression: push Concat and UnixTimestamp to TiFlash May 23, 2021
This was referenced May 23, 2021
Closed
Closed
zanmato1984
zanmato1984 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2021
@zanmato1984 zanmato1984 merged commit 4a1299d into pingcap:hanfei/release5.0-hotfix-tiflash-patch May 23, 2021
@LittleFall LittleFall deleted the patch-concat,unixtimestamp branch May 25, 2021 07:23
LittleFall added a commit to LittleFall/tidb that referenced this pull request Jun 3, 2021
@LittleFall
push Concat and UnixTimestamp to TiFlash (pingcap#24845)
30907a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@zanmato1984 zanmato1984

Labels

component/expression size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LittleFall @sre-bot @ti-chi-bot @zanmato1984