*: remove SchemaVersion in TransactionContext#24236
Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom May 11, 2021
Merged
*: remove SchemaVersion in TransactionContext#24236ti-chi-bot merged 2 commits intopingcap:masterfrom
ti-chi-bot merged 2 commits intopingcap:masterfrom
Conversation
Contributor
|
/lgtm |
Member
|
/lgtm |
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
Member
|
Please resolve the conflicts @xhebox . |
Contributor
Author
Signed-off-by: xhe <xw897002528@gmail.com>
Contributor
Author
|
/unhold |
Contributor
Author
|
Have merged the previous PR, continue to merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: a393b3e |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
May 11, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #24536 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
May 11, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-5.0 in PR #24537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The main issue: #24233
Problem Summary: Follow #24230, the bug is that when
set @@tidb_snapshot="xxxx",SchemaVersionis not updated to the old schema version.Since the update of
SchemaVersionandInfoSchemais messy(there are multiple setters forInfoschema,SchemaVersionandSnapshotInfoschema), I removedSchemaVersioncompletely and rely on the previousGetInfoSchema(which will get snapshot if there is one, then the current schema) to retrieve schema version.Check List
Tests
Release note