Skip to content

server: add tiflash fallback testcase#23248

Merged
winoros merged 3 commits intopingcap:masterfrom
xuyifangreeneyes:tiflash-fallback-testcase
Mar 12, 2021
Merged

server: add tiflash fallback testcase#23248
winoros merged 3 commits intopingcap:masterfrom
xuyifangreeneyes:tiflash-fallback-testcase

Conversation

@xuyifangreeneyes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes commented Mar 11, 2021

What problem does this PR solve?

Related PR: #22459, #23103, #23226

What is changed and how it works?

What's Changed:

Add TiFlash fallback testcase for simple TiFlash query (unary + non-streaming).

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • add TiFlash fallback testcase

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 11, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/run-all-tests

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/run-unit-test

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/run-all-tests

@winoros winoros added the sig/planner SIG: Planner label Mar 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/run-check_dev_2

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/run-integration-copr-test

@xuyifangreeneyes
Copy link
Contributor Author

xuyifangreeneyes commented Mar 11, 2021

/cc @qw4990 @hanfei1991

@ti-chi-bot ti-chi-bot requested review from hanfei1991 and qw4990 March 11, 2021 12:28
hanfei1991
hanfei1991 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@winoros winoros merged commit 413ba4c into pingcap:master Mar 12, 2021
@xuyifangreeneyes xuyifangreeneyes deleted the tiflash-fallback-testcase branch October 30, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros approved these changes

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

No one assigned

Labels

sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuyifangreeneyes @ti-chi-bot @winoros @hanfei1991