server: refine tiflash fallback testcase#23103
Conversation
server/conn_test.go
Outdated
| c.Assert(failpoint.Disable("github.com/pingcap/tidb/server/secondNextErr"), IsNil) | ||
|
|
||
| // simple TiFlash query (unary + non-streaming) | ||
| tk.MustExec("set @@tidb_allow_batch_cop=0; set @@tidb_allow_mpp=0; set @@tidb_enable_streaming=0;") |
There was a problem hiding this comment.
As I know, the enable_streaming will not affect tiflash.
|
/LGTM |
|
@hanfei1991: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@winoros: DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 6839566 |
|
/run-tics-test |
|
@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
Current tiflash fallback testcases inject failure into an improper place.
What is changed and how it works?
Use unistore to simulate tiflash fallback scenario.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note