Skip to content

types: fix clustered keyword to hint regexp#23247

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
lysu:dev-fix-cdc-create-db
Mar 11, 2021
Merged

types: fix clustered keyword to hint regexp#23247
ti-chi-bot merged 7 commits intopingcap:masterfrom
lysu:dev-fix-cdc-create-db

Conversation

@lysu
Copy link
Contributor

@lysu lysu commented Mar 11, 2021 •
edited
Loading

Signed-off-by: lysu sulifx@gmail.com

What problem does this PR solve?

Problem Summary:

fix test failure in pingcap/ticdc#1490

il>, ErrCount:0, SnapshotVersion:0"] [schema=clustered_index_test] [query="create database `clustered_index_test`"] [ts=423467362558148621]
[2021/03/11 02:09:52.880 +08:00] [DEBUG] [schema_storage.go:543] ["handle job: "] ["sql query"="create database `clustered_index_test`"] [job="ID:52, Type:create schema, State:done, SchemaState:public, SchemaID:51, TableID:0, RowCount:0, ArgLen:0, start time: 2021-03-11 02:09:50.032 +0800 CST, Err:<nil>, ErrCount:0, SnapshotVersion:0"]
[2021/03/11 02:09:52.881 +08:00] [DEBUG] [changefeed.go:707] ["DDL processed to make special features mysql-compatible"] [query="create database `/*T![clustered_index] clustered */ _index_test`"]
[2021/03/11 02:09:52.955 +08:00] [INFO] [mysql.go:246] ["Exec DDL succeeded"] [sql="create database `/*T![clustered_index] clustered */ _index_test`"]

What is changed and how it works?

What's Changed, How it Works:

add \b

Related changes

  • n/a

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • n/a

This change is Reviewable

@lysu lysu added the type/bugfix This PR fixes a bug. label Mar 11, 2021
@lysu lysu requested a review from a team as a code owner March 11, 2021 03:36
@lysu lysu requested review from wshwsh12 and removed request for a team March 11, 2021 03:36
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2021
@lysu lysu requested review from coocood and tangenta and removed request for wshwsh12 March 11, 2021 03:36
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2021
@coocood
Copy link
Member

coocood commented Mar 11, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 11, 2021

/lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@lysu
Copy link
Contributor Author

lysu commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0a131bce28e2173263c4cebf22b92c1ccdba7f4e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
tangenta
tangenta reviewed Mar 11, 2021
View reviewed changes
@lysu lysu removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@lysu
Copy link
Contributor Author

lysu commented Mar 11, 2021

/lgtm cancel

@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Mar 11, 2021
lysu added 5 commits March 11, 2021 15:05
@lysu
types: fix clustered keyword to hint regexp
65ac112 
Signed-off-by: lysu <sulifx@gmail.com>
@lysu
fix more
40450d8 
Signed-off-by: lysu <sulifx@gmail.com>
@lysu
add test case
c9b2ea0 
Signed-off-by: lysu <sulifx@gmail.com>
@lysu
fix
404be82 
Signed-off-by: lysu <sulifx@gmail.com>
@lysu
address comment, support primary key without column defs
b54bf6e 
Signed-off-by: lysu <sulifx@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@coocood
Copy link
Member

coocood commented Mar 11, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@lysu
Copy link
Contributor Author

lysu commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b54bf6e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@lysu
Copy link
Contributor Author

lysu commented Mar 11, 2021

/run-tics-test

@lysu
Copy link
Contributor Author

lysu commented Mar 11, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit bc572f3 into pingcap:master Mar 11, 2021
@0xPoe
Copy link
Member

0xPoe commented Mar 11, 2021

/merge

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

@tangenta tangenta mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tangenta tangenta tangenta approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lysu @coocood @tangenta @ti-chi-bot @0xPoe