Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Summary of Changes
Hello @hongyunyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a temporary adjustment to the CI configuration for heavy integration tests. It reconfigures all MySQL-related test groups to exclusively run the fail_over_ddl_mix_with_syncpoint test, suggesting a focused effort on debugging or validating this particular scenario within the CI pipeline. The pull request is currently marked as Work In Progress.
Highlights
- CI Test Configuration: Modified
run_heavy_it_in_ci.shto configure all 16 MySQL heavy integration test groups to exclusively execute thefail_over_ddl_mix_with_syncpointtest. This change likely aims to focus CI resources on debugging or validating this specific test case.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request appears to be a work-in-progress effort to debug a flaky integration test, fail_over_ddl_mix_with_syncpoint. The change modifies the CI test runner script to execute only this specific test across all MySQL test groups. My review highlights the risk of this approach: it temporarily disables a wide range of other important tests. I've flagged this as a high-severity issue to ensure the original test configuration is restored before merging, and I've suggested a more maintainable way to handle such debugging scenarios in the future to prevent accidental loss of test coverage.
| mysql_groups=( | ||
| # G00 | ||
| 'generate_column many_pk_or_uk' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G01 | ||
| 'api_v2 ddl_for_split_tables_with_random_move_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G02 | ||
| 'availability ddl_for_split_tables_with_failover' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G03 | ||
| 'multi_source' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G04 | ||
| 'syncpoint syncpoint_check_ts' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G05 | ||
| 'move_table ddl_for_split_tables_with_merge_and_split' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G06 | ||
| 'cdc ddl_for_split_tables_with_random_merge_and_split' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G07 | ||
| 'resolve_lock merge_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G08 | ||
| 'bank' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G09 | ||
| 'drop_many_tables' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G10 | ||
| 'default_value http_proxies' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G11 | ||
| 'ddl_reentrant force_replicate_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G12 | ||
| 'tidb_mysql_test ddl_with_random_move_table' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G13 | ||
| 'fail_over region_merge' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G14 | ||
| 'fail_over_ddl_mix' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| # G15 | ||
| # 'fail_over_ddl_mix_with_syncpoint' | ||
| 'fail_over_ddl_mix_with_syncpoint' | ||
| ) |
There was a problem hiding this comment.
It appears you're focusing all MySQL heavy integration test groups on fail_over_ddl_mix_with_syncpoint, likely to debug a flaky test. While this is a valid debugging technique, it disables a large number of other important tests, significantly reducing test coverage for the MySQL sink.
These changes must be reverted before this PR is merged to prevent a major gap in regression testing. Given the "[WIP]" status, I assume this is a temporary measure. Please restore the original test distribution before marking this PR as ready for review.
For future debugging, consider a more robust approach that doesn't require modifying the test group definitions directly. Using an environment variable to override the test list would be safer and prevent accidental merges of debugging configurations.
Example:
# Default test groups
mysql_groups=(
# G00
'generate_column many_pk_or_uk'
# G01
'api_v2 ddl_for_split_tables_with_random_move_table'
# ... and so on
)
# Override for debugging if a specific environment variable is set
if [[ -n "$DEBUG_TEST_CASE" ]]; then
for i in ${!mysql_groups[@]}; do
mysql_groups[$i]="$DEBUG_TEST_CASE"
done
fi|
@hongyunyan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #1477
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note