Skip to content

*: update the errors dependence to the latest version (#20917)#20946

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-8d35f17c17f3
Closed

*: update the errors dependence to the latest version (#20917)#20946
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-8d35f17c17f3

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #20917 to release-4.0


Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

The PR pingcap/tiup#867 introduces functions that will merge the workaround/description from errors.toml with the error message from the repository. Make sure there are no conflicts between code and error metafile, the PR pingcap/errors#31 remove workaround/description options.

What is changed and how it works?

Update the errors/parser dependencies and fix some compilation errors.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

@lonng Please fix ci

@lonng
Copy link
Contributor

lonng commented Nov 13, 2020

This PR needs the #20436 to be cherry-picked first, close this PR first and re-open after @SunRunAway cherry-pick finished.

@lonng lonng closed this Nov 13, 2020
@SunRunAway
Copy link
Contributor

SunRunAway commented Nov 24, 2020

This PR needs the #20436 to be cherry-picked first, close this PR first and re-open after @SunRunAway cherry-pick finished.

This cherry-pick has been incorporated into #21245.

@lonng lonng deleted the release-4.0-8d35f17c17f3 branch November 24, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants