server: support for client multi-statement option (#19459)#20408
Merged
ti-srebot merged 4 commits intopingcap:release-4.0from Nov 6, 2020
Merged
server: support for client multi-statement option (#19459)#20408ti-srebot merged 4 commits intopingcap:release-4.0from
ti-srebot merged 4 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
|
It looks like it needs tidb-test PR 1090 cherry picked to the release branch as well. |
|
/run-all-tests tidb-test=pr/1091 |
Contributor
|
LGTM |
Contributor
Author
|
@lysu, Thanks for your review, however we are sorry that your vote won't be count. |
Contributor
Author
|
@lysu, Thanks for your review, however we are sorry that your vote won't be count. |
Member
|
The release-4.0 branch is frozen for now, let's hold it until merging is available again. |
1 similar comment
Contributor
|
/merge |
Contributor
Author
|
Your auto merge job has been accepted, waiting for:
|
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
@ti-srebot merge failed. |
|
/run-unit-test |
Contributor
|
/merge |
Contributor
Author
|
/run-all-tests |
bb7133
added a commit
to bb7133/tidb
that referenced
this pull request
Jan 12, 2021
) (pingcap#20408)" This reverts commit 0b0c41b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #19459 to release-4.0
What problem does this PR solve?
Problem Summary:
The server previously did not correctly support the multi-statement client feature, which meant that multi-statement was always enabled. With this PR now it could be enabled or disabled (up to the client!)
What is changed and how it works?
What's Changed:
How it Works:
Related changes
Check List
Tests
The go-sql driver allows changing the multi-statement option as a connection parameter, and I have added this to the test suite. I have also manually tested against the MySQL C client, which many drivers are based on. It allows changing the options of an open connection, and TiDB correctly supports this RPC. Here is that example program:
Here is the output of the program (whether or not the tables exist is inconsequential):
Side effects
Some clients may incorrectly be depending on the current behavior! It may break for them.
Release note