Merged
Conversation
parser/parser_test.go
Outdated
Member
There was a problem hiding this comment.
I think root may be better than your name......
Member
Author
|
PTAL |
Member
|
LGTM |
stmt/stmts/create_test.go
Outdated
Member
There was a problem hiding this comment.
Replace Sql to Text would be better.
Member
Author
There was a problem hiding this comment.
They are all SQL statements.
Member
There was a problem hiding this comment.
Yes, SQL is structured query language, it doesn't means text.
But we do mean text here.
Member
Author
|
PTAL |
Member
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* restore: add error field to `DownloadResponse` Signed-off-by: 5kbpers <tangminghua@pingcap.com>
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
pingcap#195) * hotfix the bug that -T can't work which is introduced from pingcap#194 * use sameStringArray
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
…mpling#194 (pingcap#195) * hotfix the bug that -T can't work which is introduced from pingcap/dumpling#194 * use sameStringArray
crazycs520
pushed a commit
that referenced
this pull request
Oct 30, 2025
…61791) (#195) Reviewed-on: https://git.pingcap.net/pingkai/tidb/pulls/195 Reviewed-by: tianyuan <tianyuan@pingcap.cn> Co-authored-by: yuchen.ding <yuchen.ding@pingcap.cn> Co-committed-by: yuchen.ding <yuchen.ding@pingcap.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.