Skip to content

executor: fix bug of tiflash executing apply#19182

Merged
lzmhhh123 merged 3 commits intopingcap:masterfrom
hanfei1991:hanfei/fix-tiflash-apply
Aug 14, 2020
Merged

executor: fix bug of tiflash executing apply#19182
lzmhhh123 merged 3 commits intopingcap:masterfrom
hanfei1991:hanfei/fix-tiflash-apply

Conversation

@hanfei1991
Copy link
Member

What problem does this PR solve?

Issue Number: close pingcap/tiflash#999

Problem Summary:
correlated column is failed in tiflash mode.

What is changed and how it works?

What's Changed:
rebuild pd correctly when building table scan.

How it Works:

Related changes

Tests

  • Integration test
    • sql logic test

Release note

  • fix bug of tiflash executing apply

@hanfei1991 hanfei1991 requested a review from a team as a code owner August 13, 2020 10:27
@hanfei1991 hanfei1991 requested review from lzmhhh123 and wshwsh12 and removed request for a team August 13, 2020 10:27
@hanfei1991 hanfei1991 changed the title [executor] fix bug of tiflash executing apply executor: fix bug of tiflash executing apply Aug 14, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 14, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@hanfei1991 merge failed.

@hanfei1991
Copy link
Member Author

/run-all-tests

@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@hanfei1991 merge failed.

@lzmhhh123 lzmhhh123 merged commit 783d2f0 into pingcap:master Aug 14, 2020
@hanfei1991 hanfei1991 deleted the hanfei/fix-tiflash-apply branch August 14, 2020 07:09
hanfei1991 added a commit to hanfei1991/tidb that referenced this pull request Aug 14, 2020
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
hanfei1991 added a commit to ti-srebot/tidb that referenced this pull request Aug 14, 2020
executor: fix bug of tiflash executing apply (pingcap#19182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sqllogic test case(sqllogictest/test/select/select1.test) failed on tiflash

4 participants