Skip to content

planner, executor: support broadcast join for tiflash engine. (#17232)#18801

Merged
ti-srebot merged 17 commits intopingcap:release-4.0from
ti-srebot:release-4.0-29178dfa8dbe
Sep 1, 2020
Merged

planner, executor: support broadcast join for tiflash engine. (#17232)#18801
ti-srebot merged 17 commits intopingcap:release-4.0from
ti-srebot:release-4.0-29178dfa8dbe

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #17232 to release-4.0


What problem does this PR solve?

Support Broadcast Join for TiFlash Engine.

What is changed and how it works?

Change Details and Description can be referred from : https://docs.google.com/document/d/1RXW4kEKhxVS1hRsKA9Vlr-Mn94X8dMNexbuiJqfrt4A/edit?usp=sharing

Related changes

Tipb and parser is also changed:

Check List

Side effects

  • Breaking backward compatibility

TiFlash must also be updated before update for TiDB

Release note

  • Support broadcast join for tiflash.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@imtbkcat imtbkcat modified the milestones: v4.0.5, v4.0.6 Aug 4, 2020
fzhedu
fzhedu previously approved these changes Aug 14, 2020
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 14, 2020
@pingcap pingcap deleted a comment from ti-srebot Aug 31, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19048
  • 19491
  • 18950

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19518
  • 19452
  • 19439
  • 19465
  • 19491
  • 18950

zz-jason
zz-jason previously approved these changes Sep 1, 2020
@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19445
  • 19518
  • 19452
  • 19439
  • 19465
  • 19628
  • 19611
  • 19577
  • 19559
  • 19614
  • 19546
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19454

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18696
  • 18760
  • 19215
  • 19454
  • 19445
  • 19452
  • 19439
  • 19465
  • 19611
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19454

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18696
  • 18760
  • 19215
  • 19454
  • 19445
  • 19452
  • 19465
  • 19601
  • 19611
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19454
  • 19601

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8b3ff32 into pingcap:release-4.0 Sep 1, 2020
@hanfei1991 hanfei1991 deleted the release-4.0-29178dfa8dbe branch September 1, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/executor sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/new-feature type/4.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants