session,executor: tiny clean up the runStmt function#17911
Merged
tiancaiamao merged 5 commits intopingcap:masterfrom Jun 11, 2020
Merged
session,executor: tiny clean up the runStmt function#17911tiancaiamao merged 5 commits intopingcap:masterfrom
tiancaiamao merged 5 commits intopingcap:masterfrom
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #17911 +/- ##
===========================================
Coverage 79.6779% 79.6779%
===========================================
Files 524 524
Lines 143470 143470
===========================================
Hits 114314 114314
Misses 20021 20021
Partials 9135 9135 |
Member
|
LGTM |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@tiancaiamao merge failed. |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@tiancaiamao merge failed. |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@tiancaiamao merge failed. |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-integration-br-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Tiny clean up code after #17678
What is changed and how it works?
What's Changed:
runStmt, userunStmtWrapto replace it.CommonExectopreparedStmtExecwhich is only used by ExecPreparedStmtCachedPlanExecwhich is not used outside the session packageHow it Works:
Clean up
Check List
Tests
Release note