*: refactor Execute() and clean up code#17678
Merged
tiancaiamao merged 16 commits intopingcap:masterfrom Jun 9, 2020
Merged
Conversation
- implement Execute using ExecuteStmt - Execute is only for internal usage and accept only one statement - clean up the old execute function
Contributor
Author
|
/run-all-tests |
Contributor
Author
Contributor
Author
|
/run-all-test |
Codecov Report
@@ Coverage Diff @@
## master #17678 +/- ##
================================================
- Coverage 79.5690% 79.5586% -0.0104%
================================================
Files 524 524
Lines 142250 142070 -180
================================================
- Hits 113187 113029 -158
+ Misses 19968 19949 -19
+ Partials 9095 9092 -3 |
Contributor
Author
|
According @coocood 's advise, I have update |
Contributor
Author
f6aacb0 to
91b3aa4
Compare
Contributor
|
CI failed. |
Contributor
Author
|
/run-all-tests |
Contributor
|
/merge |
Contributor
|
Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
@tiancaiamao merge failed. |
Contributor
|
Please resolve the conflicts. @tiancaiamao |
Contributor
Author
Done ... I do not know why this PR conflict again and again |
jackysp
approved these changes
Jun 9, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Clean up code after #16056
The real session execute logic use
ExecuteStmt, but all the test code are still usingExecute.We need to update
Executeto useExecuteStmtto reflect the real logic.(Another direction, change all test code to use
ExecuteStmtis unpractical)What is changed and how it works?
What's Changed:
ExecuteusingExecuteStmtExecuteis only for internal usage and accept only one statementHow it Works:
Related changes
Check List
Tests
Release note