executor, privilege: introduce a new privilege for the set config statement#16847
Merged
sre-bot merged 7 commits intopingcap:masterfrom Apr 27, 2020
Merged
executor, privilege: introduce a new privilege for the set config statement#16847sre-bot merged 7 commits intopingcap:masterfrom
set config statement#16847sre-bot merged 7 commits intopingcap:masterfrom
Conversation
fixup fixup add tests fixup fixup fixup
tiancaiamao
reviewed
Apr 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #16847 +/- ##
================================================
- Coverage 80.3938% 80.3382% -0.0557%
================================================
Files 507 507
Lines 137656 137363 -293
================================================
- Hits 110667 110355 -312
- Misses 18327 18347 +20
+ Partials 8662 8661 -1 |
Contributor
|
LGTM Do not forget the special handle of |
tiancaiamao
approved these changes
Apr 27, 2020
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 27, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #16856 |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Apr 27, 2020
zz-jason
pushed a commit
that referenced
this pull request
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16846
Problem Summary: introduce a new privilege for the
set configstatement instead of using theSuperPriv.What is changed and how it works?
Wait for pingcap/parser#835.
ConfigPriv.Check List
Tests