mocktikv: avoid sorting multiple times with unstable order#15898
Merged
sre-bot merged 3 commits intopingcap:masterfrom Apr 8, 2020
Merged
mocktikv: avoid sorting multiple times with unstable order#15898sre-bot merged 3 commits intopingcap:masterfrom
sre-bot merged 3 commits intopingcap:masterfrom
Conversation
Contributor
|
Do we need to cherry-pick this to 2.1, 3.0, 3.1, 4.0 ? |
Contributor
Author
|
/run-unit
yes |
Contributor
Author
|
/run-unit-test |
Contributor
Author
|
/run-unit-test |
Contributor
Author
|
/run-all-test |
Codecov Report
@@ Coverage Diff @@
## master #15898 +/- ##
================================================
- Coverage 80.6622% 80.5019% -0.1603%
================================================
Files 504 504
Lines 136810 135701 -1109
================================================
- Hits 110354 109242 -1112
+ Misses 17972 17948 -24
- Partials 8484 8511 +27 |
Contributor
Author
|
/merge |
Contributor
|
/run-all-tests |
Contributor
Author
|
/run-cherry-picker |
1 similar comment
Contributor
Author
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-2.1 in PR #16198 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-3.0 in PR #16199 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Contributor
|
cherry pick to release-3.1 in PR #16200 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Contributor
|
cherry pick to release-4.0 in PR #16201 |
sre-bot
added a commit
that referenced
this pull request
Apr 9, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 9, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15767
Problem Summary:
The all tuples in TopN doesn't to be sorted multiple times but resulting into unstable order, so Next() does not fetch all tuples in the same order.
What is changed and how it works?
after all tuples from its child are fetched, sort them immedrately. Then fetch data from the ordered data.
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Release note