expression: use new metadata instead of implicit_args#13962
Merged
sre-bot merged 7 commits intopingcap:masterfrom Dec 9, 2019
Merged
expression: use new metadata instead of implicit_args#13962sre-bot merged 7 commits intopingcap:masterfrom
sre-bot merged 7 commits intopingcap:masterfrom
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Contributor
Author
|
I will remove the |
Contributor
Author
|
@breeswish |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13962 +/- ##
================================================
- Coverage 80.1896% 80.1524% -0.0373%
================================================
Files 480 480
Lines 120316 120196 -120
================================================
- Hits 96481 96340 -141
- Misses 16142 16164 +22
+ Partials 7693 7692 -1 |
breezewish
reviewed
Dec 8, 2019
Member
|
LGTM |
Contributor
Author
lonng
approved these changes
Dec 9, 2019
Contributor
|
/merge |
Contributor
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang zty0826@gmail.com
What problem does this PR solve?
Currently, implicit_args can only pass data with
[]Datumformat, it's not reasonable for structured metadata, such as forinoptimization, we need some metadata format like https://github.com/TennyZhuang/tikv/blob/fdb0bb3777f2bb32716a10beb776cc5e1c55125f/components/tidb_query/src/rpn_expr/impl_compare_in.rs#L125What is changed and how it works?
This PR introduce arbitrary metadata format defined with protobuf in tipb, encoding in TiDB and decoding in TiKV.
Related to pingcap/tipb#161
Check List
Tests
Code changes
Side effects
This feature will break the implicit_args format, but will not break anything really, because only
castuse implicit_args, and the pushdown switch ofcastis never open before.Related changes
Release note