expression: add more test JSON files#12874
Merged
sre-bot merged 3 commits intopingcap:masterfrom Oct 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12874 +/- ##
================================================
- Coverage 80.1011% 79.9966% -0.1045%
================================================
Files 465 465
Lines 107398 106882 -516
================================================
- Hits 86027 85502 -525
- Misses 14951 14954 +3
- Partials 6420 6426 +6 |
francis0407
reviewed
Oct 22, 2019
XuHuaiyu
reviewed
Oct 22, 2019
Contributor
XuHuaiyu
left a comment
There was a problem hiding this comment.
Addressing the comment makes this a LGTM
Contributor
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
move explain info to json files. related to #6868
What is changed and how it works?
if change the physical plans, then just recode the modified plans to the json file, instead of solving conflicts in the test file.