expression: implement vectorized builtinArithmeticMultiplyIntUnsignedSig#12834
Merged
sre-bot merged 20 commits intopingcap:masterfrom Oct 22, 2019
yongchaoyan:master
Merged
expression: implement vectorized builtinArithmeticMultiplyIntUnsignedSig#12834sre-bot merged 20 commits intopingcap:masterfrom yongchaoyan:master
sre-bot merged 20 commits intopingcap:masterfrom
yongchaoyan:master
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #12834 +/- ##
===========================================
Coverage 80.0396% 80.0396%
===========================================
Files 465 465
Lines 106957 106957
===========================================
Hits 85608 85608
Misses 14918 14918
Partials 6431 6431 |
implement builtinArithmeticMultiplyIntUnsignedSig
implement builtinArithmeticMultiplyIntUnsignedSig
implement builtinArithmeticMultiplyIntUnsignedSig
SunRunAway
reviewed
Oct 21, 2019
expression/builtin_arithmetic_vec.go
Outdated
| } | ||
| res = x[i] * y[i] | ||
| if x[i] != 0 && res/x[i] != y[i] { | ||
| result.SetNull(i, true) |
Contributor
There was a problem hiding this comment.
This line is redundant.
The vectorized framework need not to SetNull here.
Contributor
Author
There was a problem hiding this comment.
I have deleted that line
Contributor
Author
|
I hava deleted that line,please review
…------------------ 原始邮件 ------------------
发件人: "Feng Liyuan"<notifications@github.com>;
发送时间: 2019年10月21日(星期一) 下午3:49
收件人: "pingcap/tidb"<tidb@noreply.github.com>;
抄送: "这个年纪的_我"<2445674257@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [pingcap/tidb] expression: implement vectorizedbuiltinArithmeticMultiplyIntUnsignedSig (#12834)
@SunRunAway commented on this pull request.
In expression/builtin_arithmetic_vec.go:
+ + if err := b.args[1].VecEvalInt(b.ctx, input, buf); err != nil { + return err + } + + x := result.Uint64s() + y := buf.Uint64s() + result.MergeNulls(buf) + var res uint64 + for i := 0; i < n; i++ { + if result.IsNull(i) { + continue + } + res = x[i] * y[i] + if x[i] != 0 && res/x[i] != y[i] { + result.SetNull(i, true)
This line is redundant.
The vectorized framework need not to SetNull here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
|
Your auto merge job has been accepted, waiting for 12841 |
Contributor
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinArithmeticMultiplyIntUnsignedSig
What is changed and how it works?
Check List
Tests