planner: update's select should not change the output columns#12476
Merged
sre-bot merged 2 commits intopingcap:masterfrom Sep 29, 2019
Merged
planner: update's select should not change the output columns#12476sre-bot merged 2 commits intopingcap:masterfrom
sre-bot merged 2 commits intopingcap:masterfrom
Conversation
Member
Author
|
/run-all-tests |
Contributor
|
/run-common-test |
Contributor
|
/run-integration-common-test |
Codecov Report
@@ Coverage Diff @@
## master #12476 +/- ##
================================================
- Coverage 80.0557% 79.7764% -0.2794%
================================================
Files 461 462 +1
Lines 103649 102341 -1308
================================================
- Hits 82977 81644 -1333
- Misses 14751 14809 +58
+ Partials 5921 5888 -33 |
Contributor
|
/run-all-tests |
Member
Author
|
/run-common-test |
Member
Author
|
/run-integration-common-test |
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-3.0 failed |
Contributor
|
cherry pick to release-3.1 failed |
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Sep 29, 2019
winkyao
pushed a commit
that referenced
this pull request
Sep 29, 2019
Closed
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Nov 4, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Output columns should change after the select is built.
Check List
Tests
Related changes
Release note