*: remove the LightningMode from TiDB#12466
Merged
sre-bot merged 6 commits intopingcap:masterfrom Sep 29, 2019
lonng:remove-lightning-mode
Merged
*: remove the LightningMode from TiDB#12466sre-bot merged 6 commits intopingcap:masterfrom lonng:remove-lightning-mode
sre-bot merged 6 commits intopingcap:masterfrom
lonng:remove-lightning-mode
Conversation
Signed-off-by: Lonng <heng@lonng.org>
Contributor
Contributor
Author
|
@kennytm PTAL |
Codecov Report
@@ Coverage Diff @@
## master #12466 +/- ##
===========================================
Coverage 79.9711% 79.9711%
===========================================
Files 462 462
Lines 103221 103221
===========================================
Hits 82547 82547
Misses 14768 14768
Partials 5906 5906 |
Member
|
Nice clean up. |
kennytm
reviewed
Sep 29, 2019
Contributor
kennytm
left a comment
There was a problem hiding this comment.
The code is "rest LGTM" but I need to confirm if this will affect Lightning's import speed first (which is still using this flag).
|
|
||
| func (s *session) getMembufCap() int { | ||
| if s.sessionVars.LightningMode { | ||
| return kv.ImportingTxnMembufCap |
Contributor
There was a problem hiding this comment.
Could the constant ImportingTxnMembufCap be removed as well?
Signed-off-by: Lonng <heng@lonng.org>
Contributor
Author
|
@kennytm It's OK to remove the flag from TiDB-Lightning. |
|
/run-unit-test |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
The lightning does not use the TiDB's
kvencoderanymore due to performance issue.What is changed and how it works?
kvencoderfrom TiDB.Check List
Tests
Code changes
Release note