session: remove unused global variable#12460
Merged
lonng merged 4 commits intopingcap:masterfrom Sep 29, 2019
lonng:remove-unused-code
Merged
session: remove unused global variable#12460lonng merged 4 commits intopingcap:masterfrom lonng:remove-unused-code
lonng merged 4 commits intopingcap:masterfrom
lonng:remove-unused-code
Conversation
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Codecov Report
@@ Coverage Diff @@
## master #12460 +/- ##
===========================================
Coverage 79.9642% 79.9642%
===========================================
Files 462 462
Lines 103021 103021
===========================================
Hits 82380 82380
Misses 14737 14737
Partials 5904 5904 |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-common-test |
Contributor
Author
|
/run-integration-common-test |
AilinKid
approved these changes
Sep 29, 2019
Contributor
Author
|
/run-integration-common-test |
Contributor
Author
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
mockCommitErrorOnceuses to make sure gofail mockCommitError only mock commit error once. It becomes useless because of we have removedgofailfrom TiDB.sqlexe.ResultSetinterface tomultiQueryNoDelayRecordSetdirectly and remove redundant method definations.What is changed and how it works?
Remove them.
Check List
Tests
Release note