expression: Reduce memory allocation in builtinCastTimeAsDecimalSig#12439
Merged
sre-bot merged 7 commits intopingcap:masterfrom Sep 27, 2019
Merged
expression: Reduce memory allocation in builtinCastTimeAsDecimalSig#12439sre-bot merged 7 commits intopingcap:masterfrom
sre-bot merged 7 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12439 +/- ##
===========================================
Coverage 79.7515% 79.7515%
===========================================
Files 462 462
Lines 102304 102304
===========================================
Hits 81589 81589
Misses 14828 14828
Partials 5887 5887 |
SunRunAway
reviewed
Sep 27, 2019
Contributor
Author
|
/run-unit-test |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR reduces memory allocation, according to @SunRunAway 's comments in #12426
What is changed and how it works?
This change reduces ~10% memory allocation:
$ go test -v -benchmem -bench=BenchmarkVectorizedBuiltinCastFunc -run=BenchmarkVectorizedBuiltinCastFunc goos: darwin goarch: amd64 pkg: github.com/pingcap/tidb/expression ... BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsDecimalSig-VecBuiltinFunc-8 3000 490582 ns/op 116513 B/op 8023 allocs/op BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsDecimalSig-NonVecBuiltinFunc-8 3000 529352 ns/op 155393 B/op 8833 allocs/opCheck List
Tests
Code changes