executor: display column collate in show create table#12327
Merged
sre-bot merged 9 commits intopingcap:masterfrom Sep 27, 2019
tsthght:showcreatetable
Merged
executor: display column collate in show create table#12327sre-bot merged 9 commits intopingcap:masterfrom tsthght:showcreatetable
show create table#12327sre-bot merged 9 commits intopingcap:masterfrom
tsthght:showcreatetable
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12327 +/- ##
===========================================
Coverage 79.7595% 79.7595%
===========================================
Files 462 462
Lines 102216 102216
===========================================
Hits 81527 81527
Misses 14819 14819
Partials 5870 5870 |
Member
|
@tsthght Please follow the Commit Message and Pull Request Style to refactor the PR title. |
Member
|
Also, please add a UT |
COLLATE is inconsistent with MySQL when executing show create table
COLLATE is inconsistent with MySQL when executing show create tableshow create table
show create tableshow create table
Contributor
|
/run-all-tests |
Contributor
|
/rebuild |
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Nov 6, 2019
AilinKid
added a commit
to sre-bot/tidb
that referenced
this pull request
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix bug for #11831。should display collate of the column, but did not。
create table ttt4(a varchar(123) default null collate utf8mb4_unicode_ci)engine=innodb default charset=utf8mb4 collate=utf8mb4_unicode_ci;
show create table ttt4;
mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE
ttt4(avarchar(123) DEFAULT NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)
What is changed and how it works?
mysql> show create table ttt4\G
*************************** 1. row ***************************
Table: ttt4
Create Table: CREATE TABLE
ttt4(avarchar(123) COLLATE utf8mb4_unicode_ci DEFAULT NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci
1 row in set (0.00 sec)
Check List
Tests