expression: implement vectorized evaluation for builtinAsinSig#12222
Merged
zz-jason merged 4 commits intopingcap:masterfrom Sep 17, 2019
Merged
expression: implement vectorized evaluation for builtinAsinSig#12222zz-jason merged 4 commits intopingcap:masterfrom
zz-jason merged 4 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12222 +/- ##
===========================================
Coverage 81.0969% 81.0969%
===========================================
Files 454 454
Lines 98524 98524
===========================================
Hits 79900 79900
Misses 12859 12859
Partials 5765 5765 |
Contributor
|
Your auto merge job has been accepted, waiting for 12221 |
Contributor
|
@jacklightChen Please resolve conflicts... again 🤣 |
Contributor
|
/run-all-tests |
48 tasks
Contributor
|
@jacklightChen merge failed. |
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
jacklightChen
added a commit
to jacklightChen/tidb
that referenced
this pull request
Sep 17, 2019
expression: implement vectorized evaluation for builtinAsinSig (pingcap#12222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for builtinAsinSig, for #12105
What is changed and how it works?
according to benchmark, about 2 times faster than before:
Check List
Tests