*: not send tso request when point get with max tso by crazycs520 · Pull Request #11981 · pingcap/tidb

crazycs520 · 2019-09-02T09:28:41Z

What problem does this PR solve?

Point get without double read will use maxUint64 as transaction tso. Then no need to send tso request to PD.

This PR will delay to get txn future after try fast point, so it may have a little performance regression in the case of need to get tso from PD. Especially in the situation of point get with double read.

BenchMark

Environment: In my local machine: 1 TiDB, 1 PD, 5 TiKV.

Best case: Point get with max tso

Before

point get QPS is 25.7k

This PR

point get QPS is 31.4k

Worst case: Point get with double read can't use max tso

Before

point get with double read QPS is 17.8k

In this PR

point get with double read QPS is 17.1k

As you can see, since I delay use get txn future, there is a performance regression is this situation.

What is changed and how it works?

Check List

Tests

No test.

Code changes

Has exported function/method change

…oint-txn

crazycs520 · 2019-09-02T09:33:15Z

/run-all-tests

crazycs520 · 2019-09-02T09:35:10Z

/bench

crazycs520 · 2019-09-02T09:35:32Z

@tiancaiamao @coocood @jackysp PTAL

jackysp

I think @cfzjywxk is doing something similar. I have tried it before. I think if you want to change the getting ts, it's best to make the prepare statement stop executing subqueries first.

codecov · 2019-09-02T12:58:34Z

Codecov Report

Merging #11981 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11981   +/-   ##
===========================================
  Coverage   81.3309%   81.3309%           
===========================================
  Files           445        445           
  Lines         95468      95468           
===========================================
  Hits          77645      77645           
  Misses        12293      12293           
  Partials       5530       5530

mahjonp · 2019-09-02T16:05:51Z

@crazycs520 I had adjusted some configurations yesterday afternoon, so there existed an error in the benchmark result.

crazycs520 · 2019-09-02T17:22:23Z

/bench

sre-bot · 2019-09-02T18:33:38Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 728ed194c0669cb4effe6398de464c3ffbfb6608
+++ tidb: 46acbe07df9016a0fce3c5562e85ea60601df975
tikv: af70f367a38aad3305e32d8de17f60e09ea87fc3
pd: a1f8d9db4ac3e713c3259ca0979312fe3b61adac
================================================================================
test-1: < oltp_insert >
    * QPS : 21601.36 ± 0.2608% (std=40.10) delta: -0.15%
    * AvgMs : 11.84 ± 0.2744% (std=0.02) delta: 0.14%
    * PercentileMs99 : 42.31 ± 2.5526% (std=0.62) delta: 0.01%
            
test-2: < oltp_update_non_index >
    * QPS : 29636.88 ± 0.4531% (std=97.59) delta: -0.21%
    * AvgMs : 8.63 ± 0.4170% (std=0.03) delta: 0.19%
    * PercentileMs99 : 30.59 ± 1.0788% (std=0.27) delta: 1.09%
            
test-3: < oltp_read_write >
    * QPS : 37093.30 ± 0.2842% (std=71.10) delta: 0.00%
    * AvgMs : 138.57 ± 0.2656% (std=0.26) delta: -0.02%
    * PercentileMs99 : 257.95 ± 0.0000% (std=0.00) delta: 0.00%
            
test-4: < oltp_point_select >
    * QPS : 75141.81 ± 1.3490% (std=583.43) delta: -0.09%
    * AvgMs : 3.41 ± 1.2918% (std=0.03) delta: 0.18%
    * PercentileMs99 : 7.43 ± 0.0000% (std=0.00) delta: 0.00%
            
test-5: < oltp_update_index >
    * QPS : 17104.94 ± 0.8327% (std=86.63) delta: -0.20%
    * AvgMs : 14.96 ± 0.8420% (std=0.08) delta: 0.21%
    * PercentileMs99 : 48.17 ± 2.1675% (std=0.65) delta: 1.47%

https://perf.pingcap.com

planner/optimize.go

sre-bot · 2019-09-03T15:06:03Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 994e14e2e71ba16085c4e24d09d708a282beac18
+++ tidb: 7a0c170583f159d35143909851de4dee2cfc70d3
tikv: 6c420ba38cc0389c3cf21d4c5b5731ad110e6873
pd: 7baffcba6ae610f79854638aba50cd5feff9761f
================================================================================
test-1: < oltp_insert >
    * QPS : 21513.23 ± 0.1662% (std=20.90) delta: 0.02%
    * AvgMs : 11.89 ± 0.1472% (std=0.01) delta: -0.03%
    * PercentileMs99 : 42.61 ± 0.0000% (std=0.00) delta: 0.72%
            
test-2: < oltp_update_non_index >
    * QPS : 29595.16 ± 0.1788% (std=35.26) delta: -0.07%
    * AvgMs : 8.65 ± 0.1851% (std=0.01) delta: 0.01%
    * PercentileMs99 : 30.70 ± 2.1758% (std=0.41) delta: -0.35%
            
test-3: < oltp_read_write >
    * QPS : 36965.12 ± 0.3901% (std=86.92) delta: -0.18%
    * AvgMs : 139.05 ± 0.3912% (std=0.32) delta: 0.17%
    * PercentileMs99 : 257.95 ± 0.0000% (std=0.00) delta: 0.00%
            
test-4: < oltp_point_select >
    * QPS : 75528.47 ± 1.3784% (std=655.96) delta: 0.12%
    * AvgMs : 3.39 ± 1.5348% (std=0.03) delta: -0.06%
    * PercentileMs99 : 7.43 ± 0.0000% (std=0.00) delta: 0.70%
            
test-5: < oltp_update_index >
    * QPS : 17167.72 ± 0.4366% (std=56.26) delta: 0.52%
    * AvgMs : 14.91 ± 0.4191% (std=0.05) delta: -0.50%
    * PercentileMs99 : 47.99 ± 2.5379% (std=0.70) delta: -0.36%

https://perf.pingcap.com

lysu · 2020-04-13T12:28:20Z

/run-cherry-picker

lysu · 2020-04-13T15:48:27Z

/run-cherry-picker

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-13T15:49:23Z

cherry pick to release-2.1 in PR #16334

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-13T15:50:24Z

cherry pick to release-3.0 in PR #16335

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot · 2020-04-13T15:51:30Z

cherry pick to release-3.1 in PR #16336

crazycs520 added 4 commits September 2, 2019 15:19

init

6da2f10

Merge branch 'master' of https://github.com/pingcap/tidb into point-txn

5647f14

*: not send tso request when point get with max tso

9d23e5e

Merge branch 'master' into point-txn

a7d2c38

crazycs520 added sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement. labels Sep 2, 2019

crazycs520 added 2 commits September 2, 2019 17:32

fix ci

7ef8ecc

Merge branch 'point-txn' of https://github.com/crazycs520/tidb into p…

72466e9

…oint-txn

crazycs520 requested review from coocood, jackysp and tiancaiamao September 2, 2019 09:34

crazycs520 added the status/WIP label Sep 2, 2019

Merge branch 'master' of https://github.com/pingcap/tidb into point-txn

8c09522

jackysp reviewed Sep 2, 2019

View reviewed changes

fix prepare

dd783ae

crazycs520 removed the status/WIP label Sep 2, 2019

Merge branch 'master' into point-txn

46acbe0

pingcap deleted a comment from sre-bot Sep 2, 2019

tiancaiamao reviewed Sep 3, 2019

View reviewed changes

planner/optimize.go Show resolved Hide resolved

Merge branch 'master' into point-txn

53099d9

coocood reviewed Sep 3, 2019

View reviewed changes

planner/optimize.go Outdated Show resolved Hide resolved

address comment

5780cb7

crazycs520 dismissed winkyao’s stale review via d295a11 September 3, 2019 15:05

Merge branch 'master' into point-txn

965870e

winkyao approved these changes Sep 3, 2019

View reviewed changes

crazycs520 merged commit dffe293 into pingcap:master Sep 3, 2019

lysu mentioned this pull request Apr 13, 2020

session: invalid pending txn if it's a empty stmt #16325

Closed

jackysp added needs-cherry-pick-2.1 and removed needs-cherry-pick-2.1 labels Apr 13, 2020

lysu added needs-cherry-pick-2.1 labels Apr 13, 2020

lysu added the type/bugfix This PR fixes a bug. label Apr 13, 2020

sre-bot mentioned this pull request Apr 13, 2020

*: not send tso request when point get with max tso (#11981) #16334

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 13, 2020

cherry pick pingcap#11981 to release-2.1

ead4270

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 13, 2020

cherry pick pingcap#11981 to release-3.0

dcda31e

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 13, 2020

*: not send tso request when point get with max tso (#11981) #16335

Merged

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 13, 2020

cherry pick pingcap#11981 to release-3.1

d7031c2

Signed-off-by: sre-bot <sre-bot@pingcap.com>

sre-bot mentioned this pull request Apr 13, 2020

*: not send tso request when point get with max tso (#11981) #16336

Merged

sre-bot added a commit that referenced this pull request Apr 14, 2020

*: not send tso request when point get with max tso (#11981) (#16335)

6458006

zz-jason pushed a commit that referenced this pull request Apr 14, 2020

*: not send tso request when point get with max tso (#11981) (#16336)

489e313

sre-bot added a commit that referenced this pull request Apr 14, 2020

*: not send tso request when point get with max tso (#11981) (#16334)

afa43a0

Conversation

crazycs520 commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

BenchMark

Best case: Point get with max tso

Before

This PR

Worst case: Point get with double read can't use max tso

Before

In this PR

What is changed and how it works?

Check List

Uh oh!

crazycs520 commented Sep 2, 2019

Uh oh!

crazycs520 commented Sep 2, 2019

Uh oh!

crazycs520 commented Sep 2, 2019

Uh oh!

jackysp left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mahjonp commented Sep 2, 2019

Uh oh!

crazycs520 commented Sep 2, 2019

Uh oh!

sre-bot commented Sep 2, 2019

Uh oh!

Uh oh!

Uh oh!

sre-bot commented Sep 3, 2019

Uh oh!

lysu commented Apr 13, 2020

Uh oh!

lysu commented Apr 13, 2020

Uh oh!

sre-bot commented Apr 13, 2020

Uh oh!

sre-bot commented Apr 13, 2020

Uh oh!

sre-bot commented Apr 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

crazycs520 commented Sep 2, 2019 •

edited

Loading

codecov bot commented Sep 2, 2019 •

edited

Loading