expression: handle builtin add_date/sub_date func overflow#11472
Merged
wshwsh12 merged 2 commits intopingcap:masterfrom Jul 27, 2019
Merged
expression: handle builtin add_date/sub_date func overflow#11472wshwsh12 merged 2 commits intopingcap:masterfrom
wshwsh12 merged 2 commits intopingcap:masterfrom
Conversation
Member
|
hi @AndrewDi , thanks for contributing! |
230654a to
1a480aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #11472 +/- ##
================================================
+ Coverage 81.3426% 81.3643% +0.0217%
================================================
Files 424 424
Lines 90913 90917 +4
================================================
+ Hits 73951 73974 +23
+ Misses 11639 11624 -15
+ Partials 5323 5319 -4 |
Codecov Report
@@ Coverage Diff @@
## master #11472 +/- ##
================================================
+ Coverage 81.3426% 81.3621% +0.0195%
================================================
Files 424 424
Lines 90913 90917 +4
================================================
+ Hits 73951 73972 +21
+ Misses 11639 11628 -11
+ Partials 5323 5317 -6 |
Contributor
|
Please include some test cases that cover the function |
480d55f to
2f2575b
Compare
wshwsh12
reviewed
Jul 27, 2019
2f2575b to
8bd087e
Compare
8bd087e to
6a5db8e
Compare
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-3.0 in PR #11476 |
Contributor
|
cherry pick to release-2.1 in PR #11477 |
sre-bot
added a commit
that referenced
this pull request
Jul 27, 2019
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of issue #11223, fix issue #11256
What is changed and how it works?
if Year less then 0 or greater then max uint16
then return null value
Check List
Tests