store/tikv: move batch client code to file client_batch.go#11108
Merged
hicqu merged 6 commits intopingcap:masterfrom Jul 10, 2019
Merged
store/tikv: move batch client code to file client_batch.go#11108hicqu merged 6 commits intopingcap:masterfrom
hicqu merged 6 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
|
Good job! |
Codecov Report
@@ Coverage Diff @@
## master #11108 +/- ##
===========================================
Coverage 81.0184% 81.0184%
===========================================
Files 423 423
Lines 90293 90293
===========================================
Hits 73154 73154
Misses 11842 11842
Partials 5297 5297 |
|
/run-all-tests |
Contributor
Author
|
The tidb-test is still unstable... |
Contributor
Author
hicqu
approved these changes
Jul 10, 2019
Contributor
|
PTAL @lysu |
lysu
reviewed
Jul 10, 2019
Contributor
lysu
left a comment
There was a problem hiding this comment.
LGTM, @tiancaiamao maybe we should cherry-pick it to 3.0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Split file store/tikv/client.go
The batch client is complex enough, so I want to create a new file for it.
What is changed and how it works?
Move batch client related code to a separate file, no logic change.
Check List
Tests