Skip to content

model: fix null origin default value for bit column#983

Merged
tangenta merged 1 commit intopingcap:masterfrom
tangenta:fix-default-bit-col
Aug 27, 2020
Merged

model: fix null origin default value for bit column#983
tangenta merged 1 commit intopingcap:masterfrom
tangenta:fix-default-bit-col

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 26, 2020 •
edited by kennytm
Loading

What problem does this PR solve?

In PR pingcap/tidb#18036,

drop table if exists t;
create table t (a bit);
insert into t values (null);
select count(*) from t where a is null;

Expected:

+----------+
| count(*) |
+----------+
| 1        |
+----------+

But got:

+----------+
| count(*) |
+----------+
| 0        |
+----------+

If the origin default value in the BIT column is null, it should not be converted to a string.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

@tangenta tangenta requested a review from wjhuang2016 August 26, 2020 07:29
kennytm
kennytm reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Aug 26, 2020
crazycs520
crazycs520 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Aug 27, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Aug 27, 2020
@tangenta tangenta merged commit 7a050a4 into pingcap:master Aug 27, 2020
tangenta added a commit to tangenta/parser that referenced this pull request Oct 22, 2020
@tangenta
model: fix null origin default value for bit column (pingcap#983)
5225361
@tangenta tangenta mentioned this pull request Oct 22, 2020
Merged
tangenta added a commit that referenced this pull request Oct 22, 2020
@tangenta
model: fix null origin default value for bit column (#983) (#1065)
fbe80b0
tangenta added a commit to tangenta/parser that referenced this pull request Nov 11, 2020
@tangenta
model: fix null origin default value for bit column (pingcap#983)
b2f1975
@tangenta tangenta mentioned this pull request Nov 11, 2020
Merged
tangenta added a commit that referenced this pull request Nov 13, 2020
@tangenta
model: fix null origin default value for bit column (#983) (#1090)
d9bf170
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tangenta
model: fix null origin default value for bit column (pingcap#983)
50f085e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennytm kennytm kennytm left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees

No one assigned

Labels

status/LGT2 LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tangenta @kennytm @crazycs520 @ti-srebot