Skip to content

parser: rename auto rand table option#828

Merged
AilinKid merged 2 commits intopingcap:masterfrom
AilinKid:rename_auto_rand_opt
Apr 24, 2020
Merged

parser: rename auto rand table option#828
AilinKid merged 2 commits intopingcap:masterfrom
AilinKid:rename_auto_rand_opt

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 24, 2020 •
edited
Loading

What problem does this PR solve?

According to some team partners' advice, should better rename table option auto_rand to auto_rand_base, which means the base ID setting.

What is changed and how it works?

change the table option name to auto_rand_base

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • None

Related changes

  • Need to update the documentation

@AilinKid AilinKid requested a review from a team April 24, 2020 06:49
@ghost ghost requested review from kennytm and removed request for a team April 24, 2020 06:49
@AilinKid AilinKid requested review from a team and zimulala April 24, 2020 06:49
@ghost ghost removed their request for review April 24, 2020 06:49
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #828 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #828   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          40       40           
  Lines       14731    14731           
=======================================
  Hits        11532    11532           
  Misses       2517     2517           
  Partials      682      682

@kennytm
Copy link
Contributor

kennytm commented Apr 24, 2020

why call it AUTO_RAND_BASE not AUTO_RANDOM_BASE?

djshow832
djshow832 reviewed Apr 24, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor Author

AilinKid commented Apr 24, 2020

why call it AUTO_RAND_BASE not AUTO_RAND**OM**_BASE?

ok

@kennytm kennytm added the status/LGT1 LGT1 label Apr 24, 2020
kennytm
kennytm approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kennytm kennytm added the status/LGT2 LGT2 label Apr 24, 2020
@AilinKid AilinKid merged commit 8222d8b into pingcap:master Apr 24, 2020
AilinKid added a commit to AilinKid/parser that referenced this pull request Apr 24, 2020
@AilinKid
parser: rename auto rand table option (pingcap#828)
b1bbdbe
@AilinKid AilinKid mentioned this pull request Apr 24, 2020
Merged
AilinKid added a commit to AilinKid/parser that referenced this pull request Apr 24, 2020
@AilinKid
parser: rename auto rand table option (pingcap#828)
2f1fbaa
@AilinKid AilinKid mentioned this pull request Apr 24, 2020
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@AilinKid
parser: rename auto rand table option (pingcap#828)
e77a2d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djshow832 djshow832 djshow832 left review comments

@kennytm kennytm kennytm approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees

No one assigned

Labels

status/LGT1 LGT1 status/LGT2 LGT2 type/new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AilinKid @kennytm @djshow832