Remove unnecessary .(string) casting and $$ = $1 from parser.y#825
Merged
Remove unnecessary .(string) casting and $$ = $1 from parser.y#825
.(string) casting and $$ = $1 from parser.y#825Conversation
This get rid of many .(string) casts.
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 78.36% 78.18% -0.18%
==========================================
Files 40 40
Lines 14757 14638 -119
==========================================
- Hits 11564 11445 -119
Misses 2512 2512
Partials 681 681 |
Collaborator
|
Good job!
This could avoid the LGTM |
tangenta
approved these changes
Apr 27, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
…ingcap#825) * parser: use <ident> rather than <item> for string-only rules This get rid of many .(string) casts. * parser: get rid of unnecessary $$ = $1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
string, make their type<ident>so we don't need to do$x.(string).$$ = $1. So we remove all such actions.parser.gois slightly reduced from 4,084,324 bytes to 4,079,780 bytes. No observable performance gain or loss.Check List
Tests
Code changes
Side effects
Related changes