Skip to content

Update BACKUP/RESTORE syntax to match the RFC; Added IMPORT statement#824

Merged
kennytm merged 5 commits intomasterfrom
kennytm/backup-restore-2
Apr 26, 2020
Merged

Update BACKUP/RESTORE syntax to match the RFC; Added IMPORT statement#824
kennytm merged 5 commits intomasterfrom
kennytm/backup-restore-2

Conversation

@kennytm
Copy link
Contributor

@kennytm kennytm commented Apr 22, 2020

What problem does this PR solve?

Update the parser syntax to match pingcap/tidb#15274.

What is changed and how it works?

  1. Removed the S3/GCS-specific options
  2. Removed the "INCREMENTAL UNTIL" syntax, replaced by the "LAST_BACKUP" option
  3. The "SHOW BACKUP" statement is renamed to "SHOW BACKUPS".
  4. Added "IMPORT" statement (fix Design syntax for using Lightning from SQL tidb-lightning#293)

(Recommended: ignore whitespace when reviewing).

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

Related changes

@kennytm kennytm requested a review from a team April 22, 2020 11:07
@ghost ghost requested review from tangenta and removed request for a team April 22, 2020 11:07
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #824 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   78.28%   78.35%   +0.07%     
==========================================
  Files          40       40              
  Lines       14731    14755      +24     
==========================================
+ Hits        11532    11562      +30     
+ Misses       2517     2512       -5     
+ Partials      682      681       -1     

@kennytm kennytm force-pushed the kennytm/backup-restore-2 branch from 4b3663e to f24409b Compare April 23, 2020 08:12
@kennytm
Copy link
Contributor Author

kennytm commented Apr 23, 2020

PTAL @zz-jason

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 LGT1 and removed status/PTAL labels Apr 23, 2020
@kennytm
Copy link
Contributor Author

kennytm commented Apr 23, 2020

PTAL @tangenta

@kennytm
Copy link
Contributor Author

kennytm commented Apr 24, 2020

PTAL @tiancaiamao

@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Apr 26, 2020
@kennytm kennytm merged commit 1b8233b into master Apr 26, 2020
@kennytm kennytm deleted the kennytm/backup-restore-2 branch April 26, 2020 05:46
XuHuaiyu pushed a commit to XuHuaiyu/parser that referenced this pull request May 21, 2020
…pingcap#824)

* *: remove the s3/gcs-specific options

* *: replace the INCREMENTAL UNTIL syntax with LAST_BACKUP = ...

* *: use SHOW BACKUPS rather than SHOW BACKUP

* *: added IMPORT statements and options
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
…pingcap#824)

* *: remove the s3/gcs-specific options

* *: replace the INCREMENTAL UNTIL syntax with LAST_BACKUP = ...

* *: use SHOW BACKUPS rather than SHOW BACKUP

* *: added IMPORT statements and options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design syntax for using Lightning from SQL

3 participants