Skip to content

parser: add auto_random table option support#823

Merged
kennytm merged 3 commits intopingcap:masterfrom
AilinKid:auto_rand_opt
Apr 23, 2020
Merged

parser: add auto_random table option support#823
kennytm merged 3 commits intopingcap:masterfrom
AilinKid:auto_rand_opt

Conversation

@AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Apr 22, 2020

What problem does this PR solve?

supply a way to rebase auto_random from outside —— by auto_random table option

What is changed and how it works?

support auto_random table option support
the lined TiDB PR: #16750

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • add auto_random to table option

Side effects

  • Breaking backward compatibility
    (we will add it into the comment feature ID management)

Related changes

  • Need to update the documentation

@AilinKid AilinKid requested a review from a team April 22, 2020 10:00
@ghost ghost requested review from kennytm and removed request for a team April 22, 2020 10:00
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #823 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   78.27%   78.28%           
=======================================
  Files          40       40           
  Lines       14725    14731    +6     
=======================================
+ Hits        11526    11532    +6     
  Misses       2517     2517           
  Partials      682      682           

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Apr 22, 2020
@tiancaiamao
Copy link
Collaborator

tiancaiamao commented Apr 22, 2020

Is it possible that there are more than one column declared as auto random? @AilinKid

@AilinKid
Copy link
Contributor Author

Is it possible that there are more than one column declared as auto random? @AilinKid

No, only one specially with primary key

@AilinKid AilinKid requested a review from tangenta April 23, 2020 06:28
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit 1ea364b into pingcap:master Apr 23, 2020
@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Apr 23, 2020
AilinKid added a commit to AilinKid/parser that referenced this pull request Apr 24, 2020
* add auto_random table option support

* .

* .
AilinKid added a commit to AilinKid/parser that referenced this pull request Apr 24, 2020
* add auto_random table option support

* .

* .
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* add auto_random table option support

* .

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants