Skip to content

Add some tests for ‘ignore_plan_cache’, and correct a bug in parser.y#822

Merged
kennytm merged 2 commits intopingcap:masterfrom
danmay319:issue16700
Apr 22, 2020
Merged

Add some tests for ‘ignore_plan_cache’, and correct a bug in parser.y#822
kennytm merged 2 commits intopingcap:masterfrom
danmay319:issue16700

Conversation

@danmay319
Copy link
Contributor

What problem does this PR solve?

DeleteFromStmt in parser.y is not handling optimzer hints
close pingcap/tidb#16700

What is changed and how it works?

Add optimizer handler in parser.y

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@danmay319 danmay319 requested a review from a team April 22, 2020 07:41
@ghost ghost requested review from kennytm and removed request for a team April 22, 2020 07:41
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #822 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   78.27%   78.26%   -0.01%     
==========================================
  Files          40       40              
  Lines       14723    14721       -2     
==========================================
- Hits        11524    11522       -2     
  Misses       2517     2517              
  Partials      682      682              

@danmay319 danmay319 requested a review from eurekaka April 22, 2020 07:46
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kennytm kennytm added the status/LGT2 LGT2 label Apr 22, 2020
@kennytm kennytm merged commit 7329d80 into pingcap:master Apr 22, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimize hint 'ignore_plan_cache' is not captured by a delete statement

3 participants