parser: support using dash('-') in config item names#821
Merged
zz-jason merged 1 commit intopingcap:masterfrom Apr 22, 2020
Merged
parser: support using dash('-') in config item names#821zz-jason merged 1 commit intopingcap:masterfrom
zz-jason merged 1 commit intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 78.26% 78.27%
=======================================
Files 40 40
Lines 14719 14723 +4
=======================================
+ Hits 11520 11524 +4
Misses 2517 2517
Partials 682 682 |
zz-jason
approved these changes
Apr 22, 2020
Contributor
|
Should it be cherry-picked to release-4.0 branch and update the dependency of tidb repo? |
Collaborator
|
Dash(-) is not a valid char as identifier https://dev.mysql.com/doc/refman/5.7/en/identifier-qualifiers.html |
qw4990
added a commit
to qw4990/parser
that referenced
this pull request
May 21, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Close #820
After this issue(#768), the parser supports
set config name=valuesyntax, but the name doesn't support using-.We should support it since there are some config items like
label-property.reject-leader,auto-compactionwhich use-in their names.What is changed and how it works?
Introduce a new token
ConfigItemNameto support-.Check List
Tests