Skip to content

executor: cache point get plan for prepared point #541

Merged
lysu merged 2 commits intopingcap:masterfrom
cfzjywxk:ps2_parser
Sep 4, 2019
Merged

executor: cache point get plan for prepared point #541
lysu merged 2 commits intopingcap:masterfrom
cfzjywxk:ps2_parser

Conversation

@cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Sep 4, 2019

What problem does this PR solve?

add field for prepared statement to cache point get plan despite the prepared plan cache switch
the related tidb pull request https://github.com/pingcap/tidb/pull/11970

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

@coocood
Copy link
Member

coocood commented Sep 4, 2019

LGTM

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files          32       32           
  Lines        7802     7802           
=======================================
  Hits         5600     5600           
  Misses       1674     1674           
  Partials      528      528
Impacted Files Coverage Δ
ast/misc.go 74.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daf3f7...3837bc6. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   71.77%   71.77%           
=======================================
  Files          32       32           
  Lines        7802     7802           
=======================================
  Hits         5600     5600           
  Misses       1674     1674           
  Partials      528      528
Impacted Files Coverage Δ
ast/misc.go 74.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0daf3f7...d297367. Read the comment docs.

Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT2 LGT2 label Sep 4, 2019
@lysu lysu merged commit 09396da into pingcap:master Sep 4, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT2 LGT2 type/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants