parser,ast: Support for authentication plugins#1236
Merged
tiancaiamao merged 1 commit intopingcap:masterfrom Jun 7, 2021
Merged
parser,ast: Support for authentication plugins#1236tiancaiamao merged 1 commit intopingcap:masterfrom
tiancaiamao merged 1 commit intopingcap:masterfrom
Conversation
Contributor
|
/LGTM |
Merged
Collaborator
tiancaiamao
reviewed
Jun 3, 2021
Collaborator
|
rest LGTM |
Contributor
Author
|
@morgo @tiancaiamao PTAL |
morgo
approved these changes
Jun 3, 2021
Contributor
Author
|
@tiancaiamao could you have another look? |
Collaborator
|
/LGTM |
ti-srebot
approved these changes
Jun 7, 2021
tiancaiamao
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Required changes to support authentication plugins in
CREATE USERstatements.What is changed and how it works?
ast.AuthOption.AuthPluginHashString. This improves MySQL compatibility and makes it easier to use withcaching_sha2_passwordwhich can contain non-ASCII/non-printable characters.Note that the
IDENTIFIED BY PASSWORD <HashString>is still excepted, but when restoring this this gets rewritten asIDENTIFIED BY 'mysql_native_password' AS <HashString>. The former is no longer supported by MySQL 8.0.Check List
Tests
Code changes
Side effects
Note that this is based on top of:
This is needed for pingcap/tidb#24991 to be able to support
CREATE USERstatements that create users withcaching_sha2_passwordsupport.