Closed
Conversation
Contributor
Author
This is the output without this PR. Note the |
Contributor
Author
|
Looks like #1220 has a similar fix, but doesn't change |
Contributor
Author
|
/run-all-tests |
Merged
Contributor
Author
|
Changed |
tangenta
reviewed
May 28, 2021
| @@ -1 +1,14 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # If 'check.TestingT' is not used in any of the *_test.go files in a subdir no tests will run. | |||
Contributor
There was a problem hiding this comment.
Thanks! Let's run this check in the make test of Makefile.
Collaborator
|
This is included in #1232 already? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The tests in
auth/auth_test.gowere not run.To see the issue modify
auth/auth_test.goto make a test case that should fail. Then runmake test. The expected outcome is a failed test run, but in fact it doesn't show any errors.What is changed and how it works?
check.TestingT()toauth/auth_test.gotest.shto test for similar cases.Check List
Tests