*: add as of clause for `SET` and `SELECT` by nolouch · Pull Request #1206 · pingcap/parser

nolouch · 2021-04-13T09:29:53Z

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Ref pingcap/tidb#22765 (comment)

What is changed and how it works?

Check List

Tests

Unit test

CLAassistant · 2021-04-13T09:29:57Z

All committers have signed the CLA.

Signed-off-by: nolouch <nolouch@gmail.com>

parser_test.go

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2021-04-16T04:55:27Z

Some details need to discuss pingcap/tidb#22765 (comment)

Signed-off-by: nolouch <nolouch@gmail.com>

kennytm

is it possible to use a TSO as the input to the AS OF clause?

select * from a as of timestamp 424430616285806594;
-- or?
select * from a as of tso 424430616285806594;

parser_test.go

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch · 2021-04-22T12:26:36Z

@kennytm Our TSO has some logic bits, not really Unix timestamp. if really have a scene TSO as input we can add it in the future.

kennytm · 2021-04-22T18:36:20Z

/lgtm

Our TSO has some logic bits, not really Unix timestamp. if really have a scene TSO as input we can add it in the future.

I'd like to note that @@tidb_snapshot can accept both the timestamp string and TSO. Also if READ_TS_IN calculates the output using resolvedTS it's natural for the function to return a TSO than a DATETIME(6).

nolouch · 2021-04-23T03:26:18Z

If want tso as input, may we also support it in select * from a as of timestamp 424430616285806594?

kennytm · 2021-04-23T06:04:34Z

/lgtm

JmPotato · 2021-04-23T06:07:50Z

parser_test.go

 		}
 	case *ast.FuncCallExpr:
 		node.FnName.O = strings.ToLower(node.FnName.O)
+		node.SetOriginTextPosition(0)


What does this line work for?

It's cleans the some text in the node, then we can use reflect.DeepEquals to compare two statements in :

parser/parser_test.go

Lines 388 to 391 in f416dc9

c.Assert(err, IsNil, comment)

CleanNodeText(stmt)

CleanNodeText(restoreStmt)

c.Assert(restoreStmt, DeepEquals, stmt, comment)

* *: add as of clause Signed-off-by: nolouch <nolouch@gmail.com> * resolve shift-reduce conflict * *: fix and try to add test Signed-off-by: nolouch <nolouch@gmail.com> * *: add timestamp Signed-off-by: nolouch <nolouch@gmail.com> * make as of to token Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com> * add test Signed-off-by: nolouch <nolouch@gmail.com> * make of as Reserved(from mysql 8.0) Signed-off-by: nolouch <nolouch@gmail.com> * add set test case Signed-off-by: nolouch <nolouch@gmail.com> * address comment Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: tangenta <tangenta@126.com>

nolouch added the status/WIP label Apr 13, 2021

nolouch removed the status/WIP label Apr 15, 2021

xhebox self-requested a review April 15, 2021 07:14

nolouch added the status/WIP label Apr 15, 2021

nolouch force-pushed the asof branch from c6cb10f to 4abc4fb Compare April 15, 2021 08:51

nolouch and others added 3 commits April 15, 2021 16:56

*: add as of clause

a09f743

Signed-off-by: nolouch <nolouch@gmail.com>

resolve shift-reduce conflict

a68e01c

*: fix and try to add test

939d152

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the asof branch from 4abc4fb to 939d152 Compare April 15, 2021 08:59

tangenta reviewed Apr 15, 2021

View reviewed changes

parser_test.go Outdated Show resolved Hide resolved

nolouch added 2 commits April 15, 2021 21:39

*: add timestamp

069bc10

Signed-off-by: nolouch <nolouch@gmail.com>

make as of to token

d4d14bf

Signed-off-by: nolouch <nolouch@gmail.com>

address comments

b1502f8

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch removed the status/WIP label Apr 21, 2021

add test

f0365bb

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch requested review from kennytm and tangenta April 22, 2021 05:36

nolouch added 2 commits April 22, 2021 13:39

make of as Reserved(from mysql 8.0)

540101a

Signed-off-by: nolouch <nolouch@gmail.com>

add set test case

68222ca

Signed-off-by: nolouch <nolouch@gmail.com>

kennytm reviewed Apr 22, 2021

View reviewed changes

parser_test.go Show resolved Hide resolved

tangenta previously approved these changes Apr 22, 2021

View reviewed changes

ti-srebot added the status/LGT1 LGT1 label Apr 22, 2021

address comment

dd58bde

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch dismissed tangenta’s stale review via dd58bde April 22, 2021 12:21

nolouch requested a review from Yisaer April 22, 2021 12:28

Merge branch 'master' into asof

cf4ac50

ti-srebot added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Apr 23, 2021

ti-srebot approved these changes Apr 23, 2021

View reviewed changes

kennytm merged commit f416dc9 into pingcap:master Apr 23, 2021

nolouch deleted the asof branch April 23, 2021 06:07

JmPotato reviewed Apr 23, 2021

View reviewed changes

nolouch mentioned this pull request Apr 26, 2021

Replace the WITH Staleness to AS OF clause pingcap/tidb#24291

Closed

2 tasks

JmPotato mentioned this pull request Apr 27, 2021

parser: add AsOfClause for START TRANSACTION READ ONLY statement #1215

Merged

nolouch mentioned this pull request May 11, 2021

Implement Select .... AS OF syntax to support Stale Read pingcap/tidb#24557

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: add as of clause for `SET` and `SELECT`#1206

*: add as of clause for `SET` and `SELECT`#1206
kennytm merged 11 commits intopingcap:masterfrom
nolouch:asof

nolouch commented Apr 13, 2021 •

edited

Loading

Uh oh!

CLAassistant commented Apr 13, 2021 •

edited

Loading

Uh oh!

Uh oh!

nolouch commented Apr 16, 2021

Uh oh!

kennytm left a comment

Uh oh!

Uh oh!

nolouch commented Apr 22, 2021 •

edited

Loading

Uh oh!

kennytm commented Apr 22, 2021

Uh oh!

nolouch commented Apr 23, 2021

Uh oh!

kennytm commented Apr 23, 2021

Uh oh!

JmPotato Apr 23, 2021

Uh oh!

nolouch Apr 23, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	c.Assert(err, IsNil, comment)
	CleanNodeText(stmt)
	CleanNodeText(restoreStmt)
	c.Assert(restoreStmt, DeepEquals, stmt, comment)

Conversation

nolouch commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

CLAassistant commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nolouch commented Apr 16, 2021

Uh oh!

kennytm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nolouch commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm commented Apr 22, 2021

Uh oh!

nolouch commented Apr 23, 2021

Uh oh!

kennytm commented Apr 23, 2021

Uh oh!

JmPotato Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

nolouch Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nolouch commented Apr 13, 2021 •

edited

Loading

CLAassistant commented Apr 13, 2021 •

edited

Loading

nolouch commented Apr 22, 2021 •

edited

Loading

nolouch Apr 23, 2021 •

edited

Loading