Skip to content

ast, misc, parser: add FLUSH CLIENT_ERRORS_SUMMARY#1154

Merged
morgo merged 2 commits intopingcap:masterfrom
morgo:add-flush-client-errors
Jan 21, 2021
Merged

ast, misc, parser: add FLUSH CLIENT_ERRORS_SUMMARY#1154
morgo merged 2 commits intopingcap:masterfrom
morgo:add-flush-client-errors

Conversation

@morgo
Copy link
Contributor

@morgo morgo commented Jan 13, 2021

What problem does this PR solve?

This is the corresponding PR for pingcap/tidb#22382

The intention is to cherry pick this to release-5.0 and release-4.0 to assist in fixing a security issue related to multiStmt.

What is changed and how it works?

A new FLUSH CLIENT_ERRORS_SUMMARY statement is added.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Jan 15, 2021
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Jan 15, 2021
ti-srebot
ti-srebot previously approved these changes Jan 15, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Jan 15, 2021
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT2 LGT2 label Jan 21, 2021
@ti-srebot ti-srebot added the status/LGT3 LGT3. This PR looks very good to our bot. label Jan 21, 2021
@xhebox
Copy link
Contributor

xhebox commented Jan 21, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@morgo merge failed.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT4 and removed status/LGT3 LGT3. This PR looks very good to our bot. labels Jan 21, 2021
@morgo morgo merged commit 1c99899 into pingcap:master Jan 21, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants