Add sse_kms_key_id for S3 backup#607
Merged
yiwu-arbug merged 1 commit intopingcap:masterfrom Apr 23, 2020
yiwu-arbug:enc_sse
Merged
Add sse_kms_key_id for S3 backup#607yiwu-arbug merged 1 commit intopingcap:masterfrom yiwu-arbug:enc_sse
yiwu-arbug merged 1 commit intopingcap:masterfrom
yiwu-arbug:enc_sse
Conversation
Signed-off-by: Yi Wu <yiwu@pingcap.com>
This was referenced Apr 22, 2020
kennytm
reviewed
Apr 22, 2020
Contributor
kennytm
left a comment
There was a problem hiding this comment.
LGTM.
Should this be cherry-picked to 3.1?
Contributor
Author
confirmed with @gregwebs, no such needs right now. |
Contributor
Author
|
But I do want to catch up with 4.0-rc.2 branch cut. |
overvenus
approved these changes
Apr 23, 2020
hunterlxt
approved these changes
Apr 23, 2020
yiwu-arbug
pushed a commit
that referenced
this pull request
Apr 23, 2020
kennytm
pushed a commit
that referenced
this pull request
May 6, 2020
* Add sse_kms_key_id for S3 backup (#607) Add `sse_kms_key_id` field to S3 config. This is to allow using an owned KMS key when having S3 server-side encryption. Signed-off-by: Yi Wu <yiwu@pingcap.com> * update rust Signed-off-by: Yi Wu <yiwu@pingcap.com>
kennytm
added a commit
to pingcap/br
that referenced
this pull request
May 7, 2020
<!-- Thank you for working on BR! Please read BR's [CONTRIBUTING](https://github.com/pingcap/br/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR. --> Pass sse_kms_key_id when backup to S3. This is to support using user owned KMS key for server-side encryption. Pass sse_kms_key_id when backup to S3 to both tikv and when storing backupmeta in S3. Tests <!-- At least one of them must be included. --> Manual test with BR. Try: * specify kms key id on backup. restore success. * disable the kms key and try restore again. restore failed. Related changes depends on kvproto change: pingcap/kvproto#607 and tikv change: tikv/tikv#7627 Signed-off-by: Yi Wu <yiwu@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com> Co-authored-by: kennytm <kennytm@gmail.com>
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
Add `sse_kms_key_id` field to S3 config. This is to allow using an owned KMS key when having S3 server-side encryption. Signed-off-by: Yi Wu <yiwu@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
sse_kms_key_idfield to S3 config. This is to allow using an owned KMS key when having S3 server-side encryption.Signed-off-by: Yi Wu yiwu@pingcap.com