import_sst: add force partition range api#1340
Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom Aug 27, 2025
Merged
import_sst: add force partition range api#1340ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
@D3Hunter @Connor1996 @3pointer PTAL thanks |
Contributor
Author
|
/retest |
9 tasks
overvenus
reviewed
Aug 27, 2025
Cargo.toml
Outdated
| raft-proto = { git = "https://github.com/tikv/raft-rs", rev="95c532612ee6a83591fce9a8b51d6afe87b58835"} | ||
| protobuf-codegen = { git = "https://github.com/pingcap/rust-protobuf", rev="82b49fea7e696fd647b5aca0a6c6ec944eab3189" } | ||
| protobuf = { git = "https://github.com/pingcap/rust-protobuf", rev="82b49fea7e696fd647b5aca0a6c6ec944eab3189" } | ||
| protobuf-codegen = { git = "https://github.com/glorv/rust-protobuf", rev="e60d5bf8218328c98fc2aa44d1f0cf84a8b88578" } |
Member
There was a problem hiding this comment.
Before merge, please use pingcap/rust-protobuf.
Contributor
Author
overvenus
approved these changes
Aug 27, 2025
D3Hunter
approved these changes
Aug 27, 2025
proto/import_sstpb.proto
Outdated
|
|
||
| message AddPartitionRangeRequest { | ||
| Range range = 1; | ||
| uint64 ttl = 2; |
Contributor
There was a problem hiding this comment.
can you comment the ttl unit?
Contributor
Author
|
/hold |
Signed-off-by: glorv <glorvs@163.com>
D3Hunter
approved these changes
Aug 27, 2025
Contributor
Author
|
/unhold |
3pointer
approved these changes
Aug 27, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, D3Hunter, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
glorv
added a commit
to glorv/kvproto
that referenced
this pull request
Sep 8, 2025
* add force partition range api * fix typo * patch rust-protobuf * update rust-protobuf * rename and add comment Signed-off-by: glorv <glorvs@163.com> * fix --------- Signed-off-by: glorv <glorvs@163.com>
Leavrth
pushed a commit
to Leavrth/kvproto
that referenced
this pull request
Oct 21, 2025
* add force partition range api * fix typo * patch rust-protobuf * update rust-protobuf * rename and add comment Signed-off-by: glorv <glorvs@163.com> * fix --------- Signed-off-by: glorv <glorvs@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 new function in the
ImportSSTservice: