Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

hotfix the bug that -T can't work which is introduced from #194#195

Merged
kennytm merged 2 commits intopingcap:masterfrom
lichunzhu:dumplingHotFix
Nov 9, 2020
Merged

hotfix the bug that -T can't work which is introduced from #194#195
kennytm merged 2 commits intopingcap:masterfrom
lichunzhu:dumplingHotFix

Conversation

@lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Nov 9, 2020

What problem does this PR solve? 

./bin/dumpling -h xx -P yy -u root -T A.B
Release version: v4.0.8-9-g7633719
Git commit hash: 763371960a2ba2ae242d4557e887425f9a3c29cb
Git branch:      master
Build timestamp: 2020-11-09 09:53:49Z
Go version:      go version go1.13.4 darwin/amd64


parse arguments failed: failed to parse filter: cannot pass --tables-list and --filter together
github.com/pingcap/dumpling/v4/export.(*Config).ParseFromFlags
        /Users/chauncy/code/goPath/src/github.com/pingcap/dumpling/v4/export/config.go:396
main.main
        /Users/chauncy/code/goPath/src/github.com/pingcap/dumpling/cmd/dumpling/main.go:49
runtime.main
        /usr/local/go/src/runtime/proc.go:203
runtime.goexit
        /usr/local/go/src/runtime/asm_amd64.s:1357

What is changed and how it works?

Update the check rule for --filter argument.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Work well in this PR.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@lichunzhu lichunzhu requested a review from kennytm November 9, 2020 10:08
kennytm
kennytm approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 One reviewer approved (LGTM1) and removed status/PTAL labels Nov 9, 2020
@kennytm kennytm merged commit f13e421 into pingcap:master Nov 9, 2020
@lichunzhu lichunzhu deleted the dumplingHotFix branch November 9, 2020 13:44
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
hotfix the bug that -T can't work which is introduced from pingcap#194 (
fcadcab 
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
hotfix the bug that -T can't work which is introduced from pingcap#194 (
b77a6d8 
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
hotfix the bug that -T can't work which is introduced from pingcap#194 (
48af353 
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
@lichunzhu
hotfix the bug that -T can't work which is introduced from pingcap#194 (
48e0f76 
pingcap#195)

* hotfix the bug that -T can't work which is introduced from pingcap#194

* use sameStringArray
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kennytm kennytm kennytm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT1 One reviewer approved (LGTM1)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lichunzhu @kennytm